Repository navigation
Accept both Fabric fleet protocol names at reader boundaries - #4424
Merged
schickling-assistant merged 2 commits intoOct 31, 2026
Merged
schickling-assistant merged 2 commits into
schickling-assistant merged 2 commits into
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
schickling-assistant
marked this pull request as ready for review
October 31, 2026 01:56
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 01:56 — with
GitHub Actions
Inactive
schickling-assistant
had a problem deploying
to
evidence-signing
October 31, 2026 01:56 — with
GitHub Actions
Failure
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 01:56 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 01:56 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:07 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:07 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:16 — with
GitHub Actions
Inactive
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:24 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:25 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:25 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:25 — with
GitHub Actions
Inactive
Contributor
Author
|
CI scanner repair pushed as a normal commit: The conservative Rust input scanner treats the protocol prefix literal
Posted on behalf of @schickling
|
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:29 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:36 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:36 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 02:47 — with
GitHub Actions
Inactive
Contributor
Author
|
Merge record (Fabric-mesh, fractal merge rule Q26+Q31):
Posted on behalf of @schickling
|
schickling-assistant
deleted the
schickling-assistant/2026-10-31-fabric-rename-readers-a1
branch
October 31, 2026 03:02
This was referenced Oct 31, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fleet identity checks accept only
st3/fleet/<fleet>. An authenticated endpoint withfractal/fleet/<fleet>fails those checks even when its fleet and gateway match.Change
Verification
At
b2d3edea461a611b6e4e414b37592560bcee8b6e, through build admission andnix develop:cargo test -p smallclaims fleet::: 60 passed, 0 failed. Includesfleet_protocol_names_are_bound_to_the_exact_fleet,advertised_fleet_protocol_names_are_read_without_rewriting_routes,persisted_fleet_protocol_round_trip_preserves_either_name, andpairing_join_writes_configuration_only_after_helper_confirmation(both prefixes).cargo test -p fractal-fabric-adapter: 47 passed, 0 failed. Includesendpoint_protocol_accepts_both_names_only_for_this_fleetand unchanged grant/re-key/leave safety tests.Open questions
No design questions. This is accepting readers only, not dual exposure or a writer switch. PR #3644 overlaps
reconcile.rsandreconcile_tests.rs; this PR changes only its protocol check and adds a separate test. No new public capability or readiness checker. Kept draft as requested.Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree