Repository navigation
op-acceptance-tests,op-devstack,op-reth: add a windowed proof oracle to the L2 EL DSL - #23418
einar-oplabs wants to merge 1 commit into
Conversation
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
ea1e60a to
0d7e373
Compare
|
Claude: Detail moved out of the PR description when the branch was squashed into 0d7e373. It is the description as it stood before the squash, unedited, so it describes the earlier commits. WhyEvery proofs-store corruption so far (wipe handling, masked-trie overlays, the withdrawalsRoot bug, the crash gap) shows up as a wrong What
Matrix (table-driven subtests): persistence threshold {7, 50} x state masking {0, 30} x proofs path {index = Unit tests: Local verificationAn earlier run without Proofs e2e suite after the migration ( Not run: the kona-node CL variant ( Corruption check (not committed)A copy of the test started the follower with The sweep fails before any account is fetched, because the store no longer serves the block at all; a wrong proof for a served block fails one level deeper with Findings
Seams for the sibling PRs
Closes #23379 |
0d7e373 to
a74ef4c
Compare
8d28fe0 to
6266926
Compare
…to the L2 EL DSL L2ELNode.VerifyHistoricalProofsMatch sweeps the blocks a proofs-history store serves and, at each sampled block, verifies eth_getProof for a configured account set against the header's state root and against a reference node without proofs history, requiring the L2ToL1MessagePasser storage root to equal a non-empty withdrawalsRoot. It re-reads the proofs window at every block, retrying a failed read within the catch-up budget, skips a block the store pruned before or while its proof was fetched unless the caller pinned FirstBlock, and fails a sweep that verified no block. Proof and header lookups retry only while the node lags. VerifyProofsMatchAt is the single-block form; ProofsSyncStatus, which takes the caller's context, and WaitForProofsStoreBlock expose debug_proofsSyncStatus. NormalizeProofResponse and VerifyProof move from the op-reth proofs e2e utils into the DSL (as VerifyAccountProof), and that suite uses the DSL methods. OpRethConfig gains an eth proof window option so a node without proofs history can serve historical proofs, and presets.NewProofsHistoryFollowerSystem builds a sequencer, a proofs-history follower and a reference node. The proofs_history_match acceptance test runs transfers, contract writes and a withdrawal per round and sweeps a proofs follower against the sequencer over the persistence-threshold x proofs-path matrix, with reth's memory buffer target passed explicitly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6266926 to
f2add41
Compare
Every proofs-store corruption so far shows up as a wrong
eth_getProoffor some historical block, so the proofs-history scenario tests need one shared oracle that catches it without knowing the cause.L2ELNode.VerifyHistoricalProofsMatchsweeps the blocks a proofs-history store serves and checkseth_getProofagainst the header's state root and a reference node, including the message passer root againstwithdrawalsRoot. The op-reth proofs e2e helpers move into the DSL, andproofs_history_matchsweeps a follower over the persistence-threshold x proofs-path matrix.Base of the stack ending at #23448. Closes #23379. Local verification, findings and notes: detail comment.
Breakdown
AI Reviews
<ISODATETIME><COMMITID>Fable 5.1 xhigh<ISODATETIME><COMMITID>GPT-6.1-Sol xhigh<ISODATETIME><COMMITID>Opus 5.5 xhigh🤖 Generated with Claude Code