Repository navigation
Find fingerprint readers a platform names - #14675
Conversation
Brings in #18, #19, #20 and #22. The runtime pin conflicted: main pins omacom/omarchy 4d9bdc49 (#14431), which has no platform-root fingerprint detection, so this branch now pins omacom/omarchy#14675's head f317ea50, the fingerprint-readers detector on #14431. Move it to the merge commit once #14675 lands. omarchy-mac stays at #12's 0.2.0; main is still at 0.1.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
omarchy-hw-fingerprint only scanned USB, so a reader the kernel drives another way, such as a Mac's Touch ID behind its Secure Enclave, was never found: no first-run invitation, and the setup stopped at "No fingerprint sensor detected". A platform package now names such readers in /usr/share/omarchy-platform/fingerprint-readers, each as a file and the value it reads once the reader is usable. Ported from omacom/omarchy-mac 916a912, detection only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e it The docs now say the comparison drops trailing newlines, a space splits a line's fields and the file is read as the session user. A platform file that matches nothing must never hide a USB reader, so the test pairs one with a real USB reader both ways. lifecycle-dispatch.md lists the file with the others. Ported from omacom/omarchy-mac d94c8d7. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
diag/touchid also reads not-ready, unknown and failed, and not-ready contains ready, so the test now rejects each one and finds a USB reader beside a not-ready Touch ID. file-layout.md says the value is the whole file, that the file is 0444 root:root, and that the line follows the kernel's apple_sep and diag/touchid names, so a rename stops detection without an error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
f317ea5 to
00fcc45
Compare
Comments Outside DiffThese findings could not be posted inline.
|
Brings in #23. omarchy-mac stays at #12's 0.2.0 over main's 0.1.1, in the version file and the README. The runtime pin moves to omacom/omarchy#14675's head 00fcc451, the fingerprint-readers detector on quattro, since f317ea50 is no longer any PR's head. Quattro renames the platform from apple-silicon to aarch64-apple, so the platform-name tests need #24 before this pin passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brings in #26's platform names. omarchy-mac stays at #12's 0.2.0, above main's 0.1.2, in the version file and the README. The runtime pin stays on omacom/omarchy#14675's head 00fcc451, which sits on main's pinned quattro e1b0e5e9b; its note now says so. #12's one platform check, the unit's ExecCondition, already goes through omarchy-hw-apple-silicon. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ONTRIBUTING.md AGENTS.md said #12 brought both the platform file and the detector that reads it. #12 adds fingerprint-readers; omacom/omarchy#14675 teaches the runtime's omarchy-hw-fingerprint to read it. CONTRIBUTING.md now states the release rule for one-time prompts beside the cold-boot evidence rule, so merging the AGENTS.md rule doesn't make policy the contributor guide leaves out. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
It skipped unless the pinned runtime named fingerprint-readers, so CI was green without running it. The pin now names omacom/omarchy#14675's head (00fcc451: the detector on upstream quattro e1b0e5e9b), and the test no longer skips. Before this lands the pin moves to #14675's merge commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maralcbr
left a comment
There was a problem hiding this comment.
Reviewed at 00fcc45, merged onto current quattro (clean). In a Linux container hw-fingerprint-test.sh passes 23/23, and with #15512 merged as well, 23/23 and 18/18.
Approve. The whole-value match, CRLF handling, ignored relative paths, extra words and comments, and the USB fallback when no platform file matches are all right, and nothing changes until a platform ships fingerprint-readers. Greptile's P1 on bin/omarchy-drive-password isn't in this PR's files.
#14675, the runtime's fingerprint-readers detector, merged into quattro as 81fd2d23ca6e. The pin moves from its head to that merge commit, and both Touch ID integration tests run against it. That runtime also has omacom/omarchy#15326, so the reset prints its prompts through omarchy-i18n. The factory-reset test sources the reset's functions with only its stubs and the system PATH, so every prompt failed with "command not found"; it now links the runtime's omarchy-i18n and its catalogs into the fixture. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
limine-mkinitcpio skips a kernel it cannot build or install, a full boot partition for one, and still exits 0. First-boot hardware setup took that as done: it cleared the rebuild request and disarmed its service, so the machine kept booting an image without the hardware changes. The rebuild now counts only when every image Limine started reports success and nothing reported an error, limine-entry-tool's own "Failed to" lines included. Otherwise it stays owed for the next boot, for up to three tries, after which setup finishes with a warning in the journal and the install log rather than holding every boot on a rebuild. Found by Greptile on omacom#14675. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The rerun after an interrupted change treated any one slot added since as the change's new key. If the change stopped before luksChangeKey and a recovery key was enrolled before the rerun, entering the old password removed the recovery key, and entering the recovery key removed the old password's slot. luksChangeKey picks the new slot itself, so the journal can't name it, and LUKS2 leaves both keys between its two header updates. With both slots on the disk the rerun now asks for the new password, and the old one when it has only the new, and removes a slot only once the new password opens the added slot and the old password the old one. Otherwise it removes nothing and says how to settle the disk by hand. Found by Greptile on #14675. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
quattro's omacom#14675 added platform-named readers to omarchy-hw-fingerprint and its test. The script merged cleanly; the test conflicted only because both appended cases at the end, so the FocalTech cases now follow the platform ones, after the platform file is removed, and still exercise the USB scan alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both sides appended cases to hw-fingerprint-test.sh. The platform-reader cases from omacom#14675 run first and remove their fingerprint-readers file, so the wedged-reader cases still exercise the USB scan alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Builds on #14431, which added the platform files under
/usr/share/omarchy-platform/; this adds one more. Now based onquattro.omarchy-hw-fingerprintonly looks at USB, so it never finds a Mac's Touch ID, which the kernel drives through the Secure Enclave. This PR lets the platform package name such readers in a new platform file,fingerprint-readers, the same way it already describes displays, cutouts and keys. It's the detection half of omacom#694. The enrollment changes from that PR aren't included.On its own this does nothing for users. Omarchy ships no
fingerprint-readersfile, and omarchy-mac only adds one in omacom/omarchy-mac-pkgs#12, which waits on the Apple Touch ID kernel work. Until then every machine detects exactly what it does today.Thanks to Chris Kearney (@iconidentify) and DJ (@DjDeveloperr) for helping get the Touch ID hardware working.
Summary
On Apple Silicon, omarchy-mac would ship
/sys/bus/platform/drivers/apple_sep/*/diag/touchid ready. The match is on the whole value, sonot-readydoesn't count, and a platform file never hides a USB reader. The docs (file-layout.md,lifecycle-dispatch.md) give the line format, say the file is read as the session user (the real file is0444 root:root), and note that the line follows the kernel'sapple_sep/diag/touchidnames.Evidence
test/shell.d/hw-fingerprint-test.shruns a copy of the command against a fixture platform root and fixture USB devices, never the host's/usr/share/omarchy-platformor/sys.not ok - a reader the platform names is detected once its file reads the valuenot-readycase, and a platform file that hides USB fails the "USB reader beside a not-ready Touch ID" case.On an M2 Max with the aurora kernel,
diag/touchidis-r--r--r-- root rootand readsready.Merge Danger
Door: two-way. It adds a branch that only runs when the platform file exists.
Blast Radius: none until a platform package ships
fingerprint-readers. After that, the first-run fingerprint invitation and the Setup › Security › Fingerprint menu item show up on that platform.🤖 Generated with Claude Code