Repository navigation
Conversation
A unix user named omarchy produced ids like omarchy.clock. PluginRegistry rejects those, but discovery still matches the built-in, so clone reported success and the copy was never loaded. Prefix reserved ids with user. so they stay outside omarchy.*.
|
Reviewed at 755903b and reproduced on a disposable Omarchy worker whose unix user is
The change is proportionate: one guard that only fires when the derived id would start with The second opinion (Codex Medium) reviewed the same head and found no defects; that is agreement with this review, and its independence is not guaranteed. #13498 fixes the same bug by suffixing a counter, which yields Nothing is left for the author. This waits on the maintainer. |
Fixes #7118
omarchy plugin clonebuilds the new id as$USER.plus the source without theomarchy.prefix. When the unix user is namedomarchy, that isomarchy.clock. PluginRegistry andomarchy-plugin-validatereserveomarchy.*for built-ins, but discovery still matches the first-party plugin, so the CLI reports success and the copy on disk is never loaded.If the derived id starts with
omarchy., prefix it withuser.(omarchy.clockbecomesuser.omarchy.clock). Other usernames are unchanged.Verified:
Same file on the omarchy-test VM (unix user
omarchy, Omarchy 4.0.0-1): 21 pass.Not runtime-tested against a live
omarchy-shellsession. The guest is at the SDDM greeter, so there is no shell to rescan; the clone test stubsomarchy-shellthe same way the rest of that file does../test/clistill dies on this Ubuntu host atpython: command not found(onlypython3is installed) — pre-existing, unrelated.