Skip to content

Stop cloning plugins into the reserved omarchy.* namespace - #7366

Closed
686f6c61 wants to merge 1 commit into
omacom:quattrofrom
686f6c61:plugin-clone-reserved-id
Closed

686f6c61 wants to merge 1 commit into
omacom:quattrofrom
686f6c61:plugin-clone-reserved-id

Conversation

@686f6c61

Copy link
Copy Markdown

Fixes #7118

omarchy plugin clone builds the new id as $USER. plus the source without the omarchy. prefix. When the unix user is named omarchy, that is omarchy.clock. PluginRegistry and omarchy-plugin-validate reserve omarchy.* for built-ins, but discovery still matches the first-party plugin, so the CLI reports success and the copy on disk is never loaded.

If the derived id starts with omarchy., prefix it with user. (omarchy.clock becomes user.omarchy.clock). Other usernames are unchanged.

Verified:

./test/shell.d/plugin-clone-test.sh
# 21 pass, including "clone keeps USER=omarchy out of the reserved omarchy.* namespace"

Same file on the omarchy-test VM (unix user omarchy, Omarchy 4.0.0-1): 21 pass.

Not runtime-tested against a live omarchy-shell session. The guest is at the SDDM greeter, so there is no shell to rescan; the clone test stubs omarchy-shell the same way the rest of that file does. ./test/cli still dies on this Ubuntu host at python: command not found (only python3 is installed) — pre-existing, unrelated.

A unix user named omarchy produced ids like omarchy.clock. PluginRegistry
rejects those, but discovery still matches the built-in, so clone reported
success and the copy was never loaded.

Prefix reserved ids with user. so they stay outside omarchy.*.
Copilot AI balanced review requested due to automatic review settings August 18, 2026 08:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 755903b and reproduced on a disposable Omarchy worker whose unix user is omarchy, against the live shell rather than stubs.

  • Base (quattro): omarchy-plugin-clone omarchy.clock prints "Cloned … and switched to omarchy.clock" and exits 0, but omarchy-shell shell listPlugins shows no plugin cloned from omarchy.clock, and omarchy-plugin-validate rejects the clone for using the reserved omarchy.* namespace — the bug in omarchy plugin clone produces an id the registry always rejects when the user is named omarchy #7118 as described.
  • This head: the clone lands at user.omarchy.clock, passes omarchy-plugin-validate, and the running shell lists it as the enabled clone of omarchy.clock.
  • Fix reverted, test kept: the live reproduction fails again, and test/shell.d/plugin-clone-test.sh fails on "clone for user omarchy lands in the reserved omarchy.* path", so the new test does guard the fix. With the fix it passes 21 of 21.
  • ./test/cli passes on this head. Merged onto current quattro, the clone test still passes; the one test/cli failure there ("vscode generated theme references current theme file") fails on quattro alone too and is unrelated.

The change is proportionate: one guard that only fires when the derived id would start with omarchy., so every other username keeps its existing clone id. Nothing else in the repository assumes the <username>.<id> shape — removal, the plugin menu and the registry go by the full id or clonedFrom.

The second opinion (Codex Medium) reviewed the same head and found no defects; that is agreement with this review, and its independence is not guaranteed. #13498 fixes the same bug by suffixing a counter, which yields omarchy.clock2 — still in the reserved namespace, so still rejected. The second opinion, asked to compare the two without being told this conclusion, picked this pull request for the same reason.

Nothing is left for the author. This waits on the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready Good to merge verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy plugin clone produces an id the registry always rejects when the user is named omarchy

3 participants