Repository navigation
ci: execute shared interface verification on contributor PRs - #29
Conversation
Enable fail-closed quality/test and idempotently bootstrap Jazzy interface dependencies for clean shared containers. Preserve both RMW checks and existing reference-verifier artifact evidence. Signed-off-by: Arumuga Vignesh SR <129583467+wikki26@users.noreply.github.com>
panthera-momagdii
left a comment
There was a problem hiding this comment.
Reviewed head de22b0e7686d876166a4e42d245164deef12fade. This is a focused CI change: it activates the shared verification job and adds an idempotent CI-only dependency bootstrap while preserving the repository's existing schema, compatibility, consumer, and two-RMW checks. Both current head workflows pass, and no interface definitions or runtime contracts change. Approved.
KARTHIKEYAN124
left a comment
There was a problem hiding this comment.
Reviewed de22b0e. The shared verification gate now executes rather than skips, while retaining the existing interface checks. Hosted evidence confirms 15 schema tests, 14 compatibility tests, all 13 generated interfaces, the installed consumer, and message exchange with both FastDDS and CycloneDDS. The reverted-contract negative control correctly exits 42. Both CI workflows pass.
Non-blocking follow-up: pin the ROS container by digest for a stable baseline. I inspected code and hosted logs; I did not rerun the ROS build locally.
Summary
Enable the existing shared
quality/testverification gate foropenamrobot-interfacescontributor PRs (the same missingverify: truedefault identified in platform-sw #98).Changes
.github/workflows/repository-quality.ymlopts intoverify: truein a clean ROS Jazzy container (read-only PR permissions).tools/verify.shretains its real schema, compatibility, build, consumer and two-RMW message exchange checks; it now bootstraps the documented prerequisites in CI when the new shared container starts without them.ros2-jazzy.ymlinstalls the same apt dependencies and initializes rosdep.Acceptance
de22b0e:repository-quality / quality/testgenuinely executes and passes, not skipped.ROS 2 Jazzy / quality/buildremains green.tools/verify.shand retains verification evidence.Review boundary: No attempt to change the existing interface source contracts, safety requirements or main branch directly. AI-assisted CI change; DCO sign-off included.
Hosted results (29 Oct 2026)
repository-quality / repository-qualityandrepository-quality / quality/testpassed.rmw_fastrtps_cppandrmw_cyclonedds_cpp. The unchanged consumer correctly rejected a deliberately revertedNavigationStatuscontract (expected exit 42).Remaining: Maintainer review/approval and merge; an external fork-to-reviewer pilot remains a separate end-to-end gate.