Skip to content

fix: bump js-yaml resolutions to 4.3.0 for CVE-2026-59869 - #656

Merged
jonburdo merged 1 commit into
red-hat-data-services:rhoai-3.3from
NeriCarcasci:fix/js-yaml-4.3-resolutions-rhoai-3.3
Sep 16, 2026
Merged

jonburdo merged 1 commit into
red-hat-data-services:rhoai-3.3from
NeriCarcasci:fix/js-yaml-4.3-resolutions-rhoai-3.3

Conversation

@NeriCarcasci

Copy link
Copy Markdown

Related Issues/PRs

Relates to CVE-2026-59869 (js-yaml DoS via crafted YAML documents)

What changes are proposed in this pull request?

Bump the UI js-yaml dependency and yarn resolutions from 4.2.0 to 4.3.0.

The MLflow UI already resolved its direct js-yaml@^4.2.0 dependency to fixed 4.3.0. Vulnerable js-yaml@4.2.0 remained in the lockfile only because yarn resolutions forced older tooling ranges (^3.13.1, ^3.14.0, ^4.0.0, ^4.1.0) onto 4.2.0 for packages such as eslint/knip/svgo. Those tooling consumers are not part of the shipped webpack UI bundle, but scanners still flag the lockfile entry.

This change:

  • Updates the direct dependency to js-yaml@^4.3.0
  • Advances the yarn resolutions to npm:4.3.0 (including ^4.2.0)
  • Removes js-yaml@4.2.0 from yarn.lock so only the fixed version remains

How is this PR tested?

  • Existing unit/integration tests

  • New unit/integration tests

  • Manual tests

  • yarn install drops js-yaml@4.2.0; lockfile only contains js-yaml@4.3.0

  • yarn lint passed

  • yarn knip passed

Does this PR require documentation update?

  • No.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Is this PR a critical bugfix or security fix that should go into the next patch release?

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Minor releases are expected to contain larger changes, such as new features and improvements. Non-critical bug fixes and doc updates can be included as well. By default, your PR should target the next minor release.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Patch releases are typically only performed when there has been a major regression or bug in the latest release. For the sake of stability, your PR should not be included in a patch release unless it is a critical fix, or if the risk level of your PR is exceedingly low.
  • This PR is critical and needs to be in the next patch release
  • This PR can wait for the next minor release

Made with Cursor

Copilot AI review requested due to automatic review settings July 17, 2026 13:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kramaranya kramaranya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/build-konflux mlflow

@kramaranya

Copy link
Copy Markdown

/ok-to-test

Remove leftover vulnerable js-yaml@4.2.0 forced by yarn resolutions for
build tooling so the lockfile/SBOM only carries the fixed 4.3.0 already
used by the UI bundle.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Neri Carcasci <nericarcasci@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@NeriCarcasci
NeriCarcasci force-pushed the fix/js-yaml-4.3-resolutions-rhoai-3.3 branch from 687a44a to f11fbf7 Compare September 16, 2026 15:08
@jonburdo
jonburdo requested a lite review from Copilot September 16, 2026 18:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments; the dependency and lockfile updates consistently remove version 4.2.0.

Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@jonburdo
jonburdo merged commit dd73d74 into red-hat-data-services:rhoai-3.3 Sep 16, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants