Skip to content

experiment: isolate Orchid #66 buffer readback fix for Pokopia photos - #16

Closed
Framerr wants to merge 1 commit into
nx2from
experiment/pokopia-photo-readback-pr66
Closed

Framerr wants to merge 1 commit into
nx2from
experiment/pokopia-photo-readback-pr66

Conversation

@Framerr

@Framerr Framerr commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Scope

Isolated trial of the production-code change only from Orchid PR #66. Downloads requested across multiple cached GPU buffers are clipped to each buffer's address intersection before DownloadBufferMemory is called.

This is not a verified fix for Pokopia's photo corruption. The Orchid multi-change Windows build tested by the reporter made photo corruption less frequent, but introduced 3D asset flicker. That outcome cannot be attributed to this individual correction.

Isolation / safety

  • Based on current nx2; changes one implementation in src/video_core/buffer_cache/buffer_cache.h.
  • No version bump, no release asset replacement and no automatic merge.
  • Keep the Frameropia v0.0.1/0.0.2 baseline intact.
  • Run the existing Windows CI and compare photos and geometry in the same Pokopia scene.
  • If Flicker or other regression appears, close this PR without merging.

Validation needed

  • Windows build passes from this exact branch.
  • Capture >= 10 photos in the same scene on the baseline and this branch, recording clean/corrupt counts.
  • Geometry stability passes with moving camera / assets at the same location.
  • Confirm saves and loading are unaffected.

Related to #14. Original PR: MythosOfs/Orchid#66. AI-assisted port of the exact limited production change; original authors retain credit.

@Framerr Framerr self-assigned this Nov 7, 2026

Framerr commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Test result: confirmed regression (2026-11-08)

The reporter tested the isolated Frameropia build from this PR (experiment/pokopia-photo-readback-pr66) and found that every saved in-game Pokopia photograph was corrupted. Compared with the previous baseline, where some photographs were saved correctly, this change makes photo output consistently worse.

Outcome: FAIL. This isolated buffer readback range-intersection patch must not be merged as a Pokopia photo fix. This also provides a much clearer attribution than the earlier Orchid build, which included multiple changes. No claim is made about root cause or effects on other games.

Close this experimental PR without merging; preserve the branch and original code for reference. Do not change the released baseline.

@Framerr Framerr closed this Nov 7, 2026
Framerr added a commit that referenced this pull request Nov 8, 2026
Ship the validated Pokopia DMA readback fix, new transparent Frameropia F logo for README and Windows app icon, redesigned README and honest v0.0.3 release notes. Exclude rejected experiments (#16, #18, #19, #20). Preserve existing user data and executable names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant