Repository navigation
Conversation
Owner
Author
Test result: confirmed regression (2026-11-08)The reporter tested the isolated Frameropia build from this PR ( Outcome: FAIL. This isolated buffer readback range-intersection patch must not be merged as a Pokopia photo fix. This also provides a much clearer attribution than the earlier Orchid build, which included multiple changes. No claim is made about root cause or effects on other games. Close this experimental PR without merging; preserve the branch and original code for reference. Do not change the released baseline. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Isolated trial of the production-code change only from Orchid PR #66. Downloads requested across multiple cached GPU buffers are clipped to each buffer's address intersection before
DownloadBufferMemoryis called.This is not a verified fix for Pokopia's photo corruption. The Orchid multi-change Windows build tested by the reporter made photo corruption less frequent, but introduced 3D asset flicker. That outcome cannot be attributed to this individual correction.
Isolation / safety
nx2; changes one implementation insrc/video_core/buffer_cache/buffer_cache.h.Validation needed
Related to #14. Original PR: MythosOfs/Orchid#66. AI-assisted port of the exact limited production change; original authors retain credit.