Skip to content

refactor(core): extract cloud task policies - #3623

Merged
trunk-io[bot] merged 10 commits into
mainfrom
posthog-code/share-cloud-task-policies
Jul 29, 2026
Merged

refactor(core): extract cloud task policies#3623
trunk-io[bot] merged 10 commits into
mainfrom
posthog-code/share-cloud-task-policies

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

Task activity, archive, automation, execution-mode, and session decisions were not available as host-neutral core policies.

Depends on #3622
Refs PostHog/posthog#76229

Changes

Phase 1 only: I extracted the existing decisions into tested @posthog/core functions. Mobile remains unchanged in this PR, so the review is limited to the shared policy contracts.

How did you test this?

  • Full monorepo typecheck at this checkpoint
  • Final stack: 711 shared, 153 API-client, 2,599 core, and 451 mobile tests

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit dc13dbd.

@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from 533ed1f to fe1c27f Compare July 21, 2026 13:29
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from c05b44e to dc82fa7 Compare July 21, 2026 13:38
@richardsolomou richardsolomou changed the title refactor(cloud): share task domain policies refactor(cloud): share task policies across hosts Jul 21, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from 4478f7e to 9932264 Compare July 23, 2026 12:40
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 9e39cdd to 7936c58 Compare July 23, 2026 12:47
@richardsolomou richardsolomou changed the title refactor(cloud): share task policies across hosts refactor(mobile): reuse core task policies Jul 23, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 7936c58 to ac8c23a Compare July 23, 2026 13:35
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Merge posthog-code/share-cloud-task-api-..." | Re-trigger Greptile

@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 1155a8c to afb4875 Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch 2 times, most recently from 826b6dd to df92334 Compare July 24, 2026 16:41
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from afb4875 to 7428c49 Compare July 24, 2026 16:41
@richardsolomou richardsolomou changed the title refactor(mobile): reuse core task policies refactor(core): extract cloud task policies Jul 24, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from df92334 to b5e2a87 Compare July 24, 2026 16:47
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 7428c49 to 1573cb1 Compare July 24, 2026 16:47
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 1573cb1 to dcbc4b1 Compare July 24, 2026 22:26
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch 2 times, most recently from a14c3b7 to 86e2b83 Compare July 24, 2026 22:57
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from dcbc4b1 to 3a25e72 Compare July 24, 2026 22:57
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from 86e2b83 to 9bc38a5 Compare July 24, 2026 23:07
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 3a25e72 to 044e8dd Compare July 24, 2026 23:07
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Keep the extracted domain declaration as the single source after rebasing onto current main.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from 9bc38a5 to 12143f2 Compare July 28, 2026 09:06
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 044e8dd to 0fec9d1 Compare July 28, 2026 09:06
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 0fec9d1 to 7195e61 Compare July 28, 2026 09:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from 12143f2 to 2f0ea11 Compare July 28, 2026 09:28
Preserve the shared model-policy extraction while incorporating current main's Modal model support.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-api-client branch from 2f0ea11 to b69d17d Compare July 29, 2026 07:58
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch from 7195e61 to 01aec6d Compare July 29, 2026 07:58
Base automatically changed from posthog-code/share-cloud-task-api-client to main July 29, 2026 09:18
@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@trunk-io
trunk-io Bot merged commit 5f7dbf3 into main Jul 29, 2026
34 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/share-cloud-task-policies branch July 29, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants