Skip to content

refactor(core): extract shared presentation semantics - #3635

Merged
trunk-io[bot] merged 25 commits into
mainfrom
posthog-code/share-mobile-mcp-skill-transport
Jul 29, 2026
Merged

refactor(core): extract shared presentation semantics#3635
trunk-io[bot] merged 25 commits into
mainfrom
posthog-code/share-mobile-mcp-skill-transport

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

Session and inbox presentation semantics were duplicated across UI surfaces instead of being expressed as host-neutral decisions.

Depends on #3634
Refs PostHog/posthog#76229

Changes

Phase 1 only: I extracted session display, inbox engagement, activity, automation, and portability contracts into core/API-client code and switched desktop UI to them. This is the final extraction PR; mobile adoption starts in the next PR.

How did you test this?

  • Full monorepo typecheck at this checkpoint
  • Final stack: 711 shared, 153 API-client, 2,599 core, and 451 mobile tests

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit c6b211e.

@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared MCP and skill transport refactor(mobile): reuse shared transport and recovery logic Jul 21, 2026
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and recovery logic refactor(mobile): reuse shared transport and presentation logic Jul 21, 2026
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and presentation logic refactor(mobile): reuse shared transport and permission logic Jul 21, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from fcec203 to 407d084 Compare July 23, 2026 13:06
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from a5ab234 to d85caff Compare July 23, 2026 13:08
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and permission logic refactor(mobile): reuse transport and permission policies Jul 23, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 407d084 to e340cac Compare July 23, 2026 13:36
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from d85caff to 872c4ca Compare July 23, 2026 13:37
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Merge posthog-code/share-mobile-inbox-tr..." | Re-trigger Greptile

@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from dab3bbc to 29378f7 Compare July 23, 2026 16:34
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch 2 times, most recently from 6aa93d5 to eb313ca Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 29378f7 to 9d2bd25 Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from eb313ca to 5bb5175 Compare July 23, 2026 18:55
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 9d2bd25 to 408b0a2 Compare July 23, 2026 18:55
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from 539172e to a7daf92 Compare July 28, 2026 09:06
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 02b95d6 to 13aa78f Compare July 28, 2026 09:06
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 13aa78f to 84f149c Compare July 28, 2026 09:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from a7daf92 to 7a6615d Compare July 28, 2026 09:28
Preserve the shared model-policy extraction while incorporating current main's Modal model support.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from 7a6615d to 1f3ad6a Compare July 29, 2026 07:58
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 84f149c to 0a1c884 Compare July 29, 2026 07:58
Base automatically changed from posthog-code/share-mobile-inbox-transport to main July 29, 2026 11:31
@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

Preserve the shared MCP boundary while adopting main's schema-validated automation transport and reasoning coverage.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@trunk-io
trunk-io Bot merged commit 41cbc27 into main Jul 29, 2026
34 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/share-mobile-mcp-skill-transport branch July 29, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants