refactor(core): extract permission and composer semantics by richardsolomou · Pull Request #3634 · PostHog/code

richardsolomou · 2026-07-21T15:26:01Z

Problem

Desktop permission, pending-prompt, plan-approval, and composer decisions were embedded in UI state and unavailable to other hosts.

Depends on #3633
Refs PostHog/posthog#76229

Changes

Phase 1 only: I extracted those existing decisions into tested core policies and switched desktop UI to consume them. Mobile remains unchanged in this PR.

How did you test this?

Full monorepo typecheck at this checkpoint
Final stack: 711 shared, 153 API-client, 2,599 core, and 451 mobile tests

Automatic notifications

Publish to changelog?
Alert Sales and Marketing teams?

Created with PostHog Code

github-actions · 2026-07-21T15:26:34Z

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit df8b20a.}

richardsolomou · 2026-07-23T15:45:50Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps · 2026-07-23T15:50:52Z

_{Reviews (1): Last reviewed commit: "Merge posthog-code/share-repository-inte..." | Re-trigger Greptile}

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

Keep the extracted domain declaration as the single source after rebasing onto current main. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

Preserve the shared model-policy extraction while incorporating current main's Modal model support. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

trunk-io · 2026-07-29T10:44:34Z

😎 Merged successfully - details.

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from 9fa5d73 to d33f9fc Compare July 23, 2026 13:04

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from fcec203 to 407d084 Compare July 23, 2026 13:06

richardsolomou changed the title ~~refactor(mobile): reuse shared inbox transport~~ refactor(mobile): reuse inbox transport Jul 23, 2026

richardsolomou mentioned this pull request Jul 23, 2026

refactor(core): extract shared presentation semantics #3635

Merged

2 tasks

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from d33f9fc to 34b58d2 Compare July 23, 2026 13:36

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 407d084 to e340cac Compare July 23, 2026 13:36

richardsolomou marked this pull request as ready for review July 23, 2026 15:47

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from dab3bbc to 29378f7 Compare July 23, 2026 16:34

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from 2c40bfe to a7ef739 Compare July 23, 2026 17:28

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 29378f7 to 9d2bd25 Compare July 23, 2026 17:28

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from a7ef739 to ac5fe9a Compare July 23, 2026 18:55

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 9d2bd25 to 408b0a2 Compare July 23, 2026 18:55

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from ac5fe9a to e6b7199 Compare July 24, 2026 16:41

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 408b0a2 to 5a95631 Compare July 24, 2026 16:42

richardsolomou changed the title ~~refactor(mobile): reuse inbox transport~~ refactor(core): extract permission and composer semantics Jul 24, 2026

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from e6b7199 to 343feed Compare July 24, 2026 16:47

jonathanlab approved these changes Jul 28, 2026

View reviewed changes

richardsolomou added 5 commits July 28, 2026 12:03

refactor(shared): extract task contracts and model policy

484a6c7

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

fix(models): preserve GLM effort policy

ec5fb80

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

test(ui): wait for async content

fa2dda4

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

test(ui): isolate plan approval presentation

0960bc3

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

fix(shared): Preserve canonical task artifacts

3f608f2

Keep the extracted domain declaration as the single source after rebasing onto current main. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from 4722c58 to 72c431a Compare July 28, 2026 09:06

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 02b95d6 to 13aa78f Compare July 28, 2026 09:06

test(agent): match canonical model picker order

9c4235c

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from 72c431a to 468d1a8 Compare July 28, 2026 09:28

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 13aa78f to 84f149c Compare July 28, 2026 09:28

richardsolomou added 12 commits July 29, 2026 10:53

Merge main into shared cloud task foundations

b4e9084

Preserve the shared model-policy extraction while incorporating current main's Modal model support. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(api-client): extract cloud task transport

b69d17d

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract cloud task policies

01aec6d

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): rename cloud task service as engine

53e5383

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract portable cloud task engine

2245a2e

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract repository integration semantics

36f9b39

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract pending prompt recovery

3003336

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract plan approval presentation

b5204c8

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract permission option presentation

7ccd259

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract composer controls

046422e

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

refactor(core): extract composer model policy

37f1c0b

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

fix(core): prefer streamed plan content

0a1c884

Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 84f149c to 0a1c884 Compare July 29, 2026 07:58

richardsolomou force-pushed the posthog-code/share-repository-integration-semantics branch from 468d1a8 to 36f9b39 Compare July 29, 2026 07:58

Base automatically changed from posthog-code/share-repository-integration-semantics to main July 29, 2026 10:44

Merge branch 'main' into posthog-code/share-mobile-inbox-transport

df8b20a

trunk-io Bot merged commit a52ddb0 into main Jul 29, 2026
34 checks passed

trunk-io Bot deleted the posthog-code/share-mobile-inbox-transport branch July 29, 2026 11:31

Navigation Menu

Uh oh!

refactor(core): extract permission and composer semantics - #3634

refactor(core): extract permission and composer semantics#3634
trunk-io[bot] merged 19 commits into
mainfrom
posthog-code/share-mobile-inbox-transport

richardsolomou commented Jul 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

richardsolomou commented Jul 23, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jul 23, 2026

Uh oh!

trunk-io Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

richardsolomou commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this?

Automatic notifications

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardsolomou commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 23, 2026

Uh oh!

trunk-io Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

richardsolomou commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

richardsolomou commented Jul 23, 2026 •

edited

Loading

trunk-io Bot commented Jul 29, 2026 •

edited

Loading