refactor(mobile): adopt shared task runtime - #3637
Merged
trunk-io[bot] merged 27 commits intoJul 29, 2026
Merged
Conversation
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 23, 2026 13:08
a5ab234 to
d85caff
Compare
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 23, 2026 13:11
2f7181a to
431749d
Compare
2 tasks
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 23, 2026 13:37
d85caff to
872c4ca
Compare
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 23, 2026 13:39
431749d to
b0dd0b1
Compare
This was referenced Jul 23, 2026
Member
Author
This was referenced Jul 23, 2026
richardsolomou
marked this pull request as ready for review
July 23, 2026 15:47
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
apps/mobile/src/features/tasks/composer/options.ts:62-64
**Recording stop becomes task stop**
When a remote user message starts an agent turn while the local user is recording, `canStop` takes precedence over `isRecording`, so the unchanged stop control cancels the agent turn instead of stopping voice capture, leaving the recording active and potentially losing the user's speech.
### Issue 2 of 2
apps/mobile/src/features/tasks/composer/TaskChatComposer.tsx:500-508
**Unchanged reasoning triggers side effects**
Selecting a model that supports the current reasoning effort still invokes `onReasoningChange`, causing a redundant `set_config_option` cloud command and unnecessary persisted Zustand updates.
Reviews (1): Last reviewed commit: "Merge posthog-code/share-mobile-mcp-skil..." | Re-trigger Greptile |
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 23, 2026 16:34
66a119b to
6aa93d5
Compare
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 23, 2026 16:34
188b515 to
68356b7
Compare
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 23, 2026 17:28
6aa93d5 to
eb313ca
Compare
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 23, 2026 17:28
68356b7 to
6e7681e
Compare
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 23, 2026 18:55
eb313ca to
5bb5175
Compare
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 23, 2026 18:55
6e7681e to
44c040d
Compare
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 24, 2026 16:42
5bb5175 to
b7411a3
Compare
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 28, 2026 09:28
bc6313f to
f5eab92
Compare
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 28, 2026 09:28
a7daf92 to
7a6615d
Compare
Preserve the shared model-policy extraction while incorporating current main's Modal model support. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
richardsolomou
force-pushed
the
posthog-code/share-composer-control-semantics
branch
from
July 29, 2026 07:58
f5eab92 to
5299c52
Compare
richardsolomou
force-pushed
the
posthog-code/share-mobile-mcp-skill-transport
branch
from
July 29, 2026 07:58
7a6615d to
1f3ad6a
Compare
Base automatically changed from
posthog-code/share-mobile-mcp-skill-transport
to
main
July 29, 2026 11:49
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
Keep the mobile composer migration while adopting main's canonical automation and reasoning implementations. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Mobile still maintains its own task contracts, API transport, policies, and cloud-task stream after the shared equivalents have been extracted.
Depends on #3635
Refs PostHog/posthog#76229
Changes
Phase 2: I migrated mobile task and automation consumers onto the shared contracts, API client, policies, and engine, then removed the replaced mobile implementations. The shared desktop behavior is already established by the preceding PRs, so this review is limited to the mobile migration.
How did you test this?
Automatic notifications
Created with PostHog Code