Skip to content

refactor(mobile): adopt shared task runtime - #3637

Merged
trunk-io[bot] merged 27 commits into
mainfrom
posthog-code/share-composer-control-semantics
Jul 29, 2026
Merged

refactor(mobile): adopt shared task runtime#3637
trunk-io[bot] merged 27 commits into
mainfrom
posthog-code/share-composer-control-semantics

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

Mobile still maintains its own task contracts, API transport, policies, and cloud-task stream after the shared equivalents have been extracted.

Depends on #3635
Refs PostHog/posthog#76229

Changes

Phase 2: I migrated mobile task and automation consumers onto the shared contracts, API client, policies, and engine, then removed the replaced mobile implementations. The shared desktop behavior is already established by the preceding PRs, so this review is limited to the mobile migration.

How did you test this?

  • Full monorepo typecheck at this checkpoint
  • Final stack: 711 shared, 153 API-client, 2,599 core, and 451 mobile tests

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found 1 issue in 1 file · 1 warning.

1 warning

src/features/chat/components/ToolMessage.tsx

Reviewed by React Doctor for commit 4892f7f.

@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from a5ab234 to d85caff Compare July 23, 2026 13:08
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from 2f7181a to 431749d Compare July 23, 2026 13:11
@richardsolomou richardsolomou changed the title refactor(mobile): share composer control semantics refactor(mobile): align composer model policy Jul 23, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from d85caff to 872c4ca Compare July 23, 2026 13:37
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from 431749d to b0dd0b1 Compare July 23, 2026 13:39
@richardsolomou richardsolomou changed the title refactor(mobile): align composer model policy refactor(core): own composer model policy Jul 23, 2026
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/mobile/src/features/tasks/composer/options.ts:62-64
**Recording stop becomes task stop**

When a remote user message starts an agent turn while the local user is recording, `canStop` takes precedence over `isRecording`, so the unchanged stop control cancels the agent turn instead of stopping voice capture, leaving the recording active and potentially losing the user's speech.

### Issue 2 of 2
apps/mobile/src/features/tasks/composer/TaskChatComposer.tsx:500-508
**Unchanged reasoning triggers side effects**

Selecting a model that supports the current reasoning effort still invokes `onReasoningChange`, causing a redundant `set_config_option` cloud command and unnecessary persisted Zustand updates.

Reviews (1): Last reviewed commit: "Merge posthog-code/share-mobile-mcp-skil..." | Re-trigger Greptile

Comment thread apps/mobile/src/features/tasks/composer/options.ts Outdated
Comment thread apps/mobile/src/features/tasks/composer/TaskChatComposer.tsx Outdated
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from 66a119b to 6aa93d5 Compare July 23, 2026 16:34
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from 188b515 to 68356b7 Compare July 23, 2026 16:34
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from 6aa93d5 to eb313ca Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from 68356b7 to 6e7681e Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from eb313ca to 5bb5175 Compare July 23, 2026 18:55
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from 6e7681e to 44c040d Compare July 23, 2026 18:55
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from 5bb5175 to b7411a3 Compare July 24, 2026 16:42
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from bc6313f to f5eab92 Compare July 28, 2026 09:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from a7daf92 to 7a6615d Compare July 28, 2026 09:28
Preserve the shared model-policy extraction while incorporating current main's Modal model support.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-composer-control-semantics branch from f5eab92 to 5299c52 Compare July 29, 2026 07:58
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from 7a6615d to 1f3ad6a Compare July 29, 2026 07:58
Base automatically changed from posthog-code/share-mobile-mcp-skill-transport to main July 29, 2026 11:49
@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

Keep the mobile composer migration while adopting main's canonical automation and reasoning implementations.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@trunk-io
trunk-io Bot merged commit 5297f7f into main Jul 29, 2026
34 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/share-composer-control-semantics branch July 29, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants