refactor(core): rename cloud task service as engine - #3624
Merged
Conversation
This was referenced Jul 21, 2026
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 21, 2026 13:38
c05b44e to
dc82fa7
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 21, 2026 13:46
2dafbcd to
1b48f46
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 23, 2026 12:47
9e39cdd to
7936c58
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 23, 2026 12:55
32895be to
54e687e
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 23, 2026 13:35
7936c58 to
ac8c23a
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 23, 2026 13:35
54e687e to
25563d8
Compare
This was referenced Jul 23, 2026
Member
Author
This was referenced Jul 23, 2026
richardsolomou
marked this pull request as ready for review
July 23, 2026 15:47
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
packages/core/src/cloud-task/cloud-task-engine.ts:2165
**Archived fetch can hang hydration**
When a terminal run has no persisted session-log rows and its archive request stalls, this unbounded fetch never emits a snapshot or retryable error, leaving the mobile task session loading indefinitely.
### Issue 2 of 2
packages/core/src/cloud-task/cloud-task-engine.ts:2169-2170
**Malformed line discards entire archive**
When an archived NDJSON log contains one malformed line, parsing the complete array throws and returns `null`, causing hydration to reject every otherwise valid entry; the previous mobile parser skipped malformed lines and retained the remaining task history.
Reviews (1): Last reviewed commit: "fix(core): restore archived cloud task l..." | Re-trigger Greptile |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 23, 2026 17:28
1155a8c to
afb4875
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 23, 2026 17:28
bdfa389 to
5e38056
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 24, 2026 16:41
afb4875 to
7428c49
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 24, 2026 16:41
5e38056 to
f703289
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 24, 2026 16:47
7428c49 to
1573cb1
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 24, 2026 16:47
f703289 to
5bbe73f
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 24, 2026 22:26
1573cb1 to
dcbc4b1
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
2 times, most recently
from
July 24, 2026 22:57
ae97a33 to
059b248
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 24, 2026 22:57
dcbc4b1 to
3a25e72
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 24, 2026 23:07
059b248 to
ee6ce05
Compare
jonathanlab
approved these changes
Jul 28, 2026
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Keep the extracted domain declaration as the single source after rebasing onto current main. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 28, 2026 09:06
ee6ce05 to
df1e4cc
Compare
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 28, 2026 09:28
0fec9d1 to
7195e61
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 28, 2026 09:28
df1e4cc to
6b33a73
Compare
Preserve the shared model-policy extraction while incorporating current main's Modal model support. Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-policies
branch
from
July 29, 2026 07:58
7195e61 to
01aec6d
Compare
richardsolomou
force-pushed
the
posthog-code/share-cloud-task-engine
branch
from
July 29, 2026 07:58
6b33a73 to
53e5383
Compare
|
😎 Merged successfully - details. |
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The cloud-task implementation needs to become a reusable engine, but keeping
cloud-task.tsas a wrapper in the same diff prevents GitHub from showing the implementation move.Depends on #3623
Refs PostHog/posthog#76229
Changes
Phase 1 only: I renamed
cloud-task.tstocloud-task-engine.tsbyte-for-byte and updated imports. GitHub shows this as a 100% rename; the engine refactor and wrapper are deferred to the next PR.How did you test this?
Automatic notifications
Created with PostHog Code