[hermes] Add one more UI test #3011
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new UI test for syntax errors and includes several small improvements to the UI test shim. The changes improve code clarity and structure, such as making a function private and refactoring logic for better readability. I've found one medium-severity issue related to a potential panic when handling file paths, and I've provided a detailed suggestion for a more robust implementation.
| } | ||
|
|
||
| pub fn emit_rustc_json(e: &HermesError, source: &str, file: &str) { | ||
| fn emit_rustc_json(e: &HermesError, source: &str, file: &str) { |
There was a problem hiding this comment.
This function is called with file_path.to_str().unwrap() on line 47. This can cause a panic if the file path contains non-UTF-8 characters. To make the code more robust, consider changing this function's signature to accept a &Path instead of a &str.
This would allow you to use file.display().to_string() inside this function to safely handle the conversion, and change the call site to pass &file_path directly, removing the .unwrap().
Suggested changes:
-
Update this function's signature:
fn emit_rustc_json(e: &HermesError, source: &str, file: &std::path::Path) {
-
Update the
file_nameassignment on line 110:file_name: file.display().to_string(),
-
Update the call on line 47:
emit_rustc_json(&e, source, &file_path);
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G3220747e90b678c598c506be49219a8f75118988 #3011 +/- ##
==========================================================================
Coverage 91.87% 91.87%
==========================================================================
Files 20 20
Lines 6057 6057
==========================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2
branch
from
36e639f to
53c4584
Compare
joshlf
force-pushed
the
G3220747e90b678c598c506be49219a8f75118988
branch
from
75e4b1c to
03142cc
Compare
gherrit-pr-id: Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2
joshlf
force-pushed
the
G3220747e90b678c598c506be49219a8f75118988
branch
from
03142cc to
db80a43
Compare
joshlf
force-pushed
the
Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2
branch
from
53c4584 to
9b57bca
Compare
2 participants
mod foo;declarations #3008Latest Update: v27 — Compare vs v26
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2 && git checkout -b pr-Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2 FETCH_HEADCheckout
git fetch origin refs/heads/Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.