[hermes] Add some trace/debug logging #3012
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the diagnostic capabilities of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2 #3012 +/- ##
==========================================================================
Coverage 91.87% 91.87%
==========================================================================
Files 20 20
Lines 6057 6057
==========================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds trace and debug logging across several files to improve the tool's observability. The changes are straightforward and well-implemented. I've suggested a minor formatting improvement for a long log line to enhance readability, but overall, the changes are good.
| target_dir: &Path, | ||
| skip_paths: &HashSet<PathBuf>, | ||
| ) -> Result<()> { | ||
| log::trace!("create_symlink_skeleton(source_root: {:?}, dest_root: {:?}, target_dir: {:?}, skip_paths_count: {})", source_root, dest_root, target_dir, skip_paths.len()); |
There was a problem hiding this comment.
This line is quite long and exceeds typical line length limits (e.g., 100-120 characters), which can harm readability and maintainability. Consider formatting this log::trace! macro call across multiple lines to improve clarity.
log::trace!(
"create_symlink_skeleton(source_root: {:?}, dest_root: {:?}, target_dir: {:?}, skip_paths_count: {})",
source_root,
dest_root,
target_dir,
skip_paths.len()
);
joshlf
force-pushed
the
Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2
branch
from
36e639f to
53c4584
Compare
joshlf
force-pushed
the
G833f306c404eb4d4f3d920a8b169a5570b3806a4
branch
from
c4916be to
1b5bc18
Compare
gherrit-pr-id: G833f306c404eb4d4f3d920a8b169a5570b3806a4
joshlf
force-pushed
the
G833f306c404eb4d4f3d920a8b169a5570b3806a4
branch
from
1b5bc18 to
b6dc5d4
Compare
joshlf
force-pushed
the
Gbeb9a3b076d434abb7e0a799fdb18c4ad9fb87a2
branch
from
53c4584 to
9b57bca
Compare
2 participants
mod foo;declarations #3008Latest Update: v26 — Compare vs v25
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G833f306c404eb4d4f3d920a8b169a5570b3806a4 && git checkout -b pr-G833f306c404eb4d4f3d920a8b169a5570b3806a4 FETCH_HEADCheckout
git fetch origin refs/heads/G833f306c404eb4d4f3d920a8b169a5570b3806a4 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G833f306c404eb4d4f3d920a8b169a5570b3806a4 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.