[hermes] Minor cleanup in transform::apply_edits

[joshlf]

---

• 　  [hermes] Add test for multi-byte UTF-8 characters #3027
• 👉 [hermes] Minor cleanup in transform::apply_edits #3025
• 　  [hermes] Take responsibility for all terminal UI #3019
• 　  [hermes] Get tests passing again #3018
• 　  [hermes] Add some tests for Charon invocation #3015
• 　  [hermes] Add Charon step #3014
• 　  [hermes] Isolate shadow crate from other artifacts #3013
• 　  [hermes] Add some trace/debug logging #3012
• 　  [hermes] Add one more UI test #3011
• 　  [hermes] Add fixture testing #3010
• 　  [hermes] Finish shadow crate creation #3009
• 　  [hermes] Discover mod foo; declarations #3008
• 　  [hermes] Resolve Cargo and Hermes target dirs #3007
• 　  [hermes] Add shadow copy creation #3006
• 　  [hermes] Add package/target/root resolution #3005
• 　  [hermes] Add source code transformation #3004
• 　  [hermes] Add UI testing #3003
• 　  [hermes] Initial commit of parser #3002

Latest Update: v3 — Compare vs v2

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v2	v1	Base
v3	vs v2	vs v1	vs Base
v2		vs v1	vs Base
v1			vs Base

⬇️ Download this PR

Branch

git fetch origin refs/heads/GI7PO52I2CB3PQQC425CDLSKBPLNCSPM3 && git checkout -b pr-GI7PO52I2CB3PQQC425CDLSKBPLNCSPM3 FETCH_HEAD

Checkout

git fetch origin refs/heads/GI7PO52I2CB3PQQC425CDLSKBPLNCSPM3 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/GI7PO52I2CB3PQQC425CDLSKBPLNCSPM3 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/GI7PO52I2CB3PQQC425CDLSKBPLNCSPM3

Stacked PRs enabled by GHerrit.

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor code cleanup within the hermes tool, specifically in the transform::apply_edits function. The change refactors a byte comparison condition to utilize Rust's matches! macro, enhancing code readability and conciseness without altering the function's behavior.

Highlights

• Code Refactoring: Replaced a boolean && expression with the more idiomatic matches! macro for byte comparison within the apply_edits function, improving code readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tools/hermes/src/transform.rs
  • Refactored byte comparison in apply_edits to use the matches! macro for improved readability.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a minor but valuable cleanup in the apply_edits function. The use of the matches! macro instead of a chain of != comparisons is more idiomatic in Rust and improves the readability of the code. The change is correct and has no performance or security implications. This is a good refinement.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (34f4c95) to head (bff925c).

Additional details and impacted files

@@                            Coverage Diff                             @@
##           Gc48bae5a713c0931a406c162369f4a30ddc1f2b3    #3025   +/-   ##
==========================================================================
  Coverage                                      91.87%   91.87%           
==========================================================================
  Files                                             20       20           
  Lines                                           6057     6057           
==========================================================================
  Hits                                            5565     5565           
  Misses                                           492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[joshlf]

Squashed into #3004