[hermes] Isolate shadow crate from other artifacts #3013
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the directory structure for Hermes build artifacts, specifically isolating the "shadow crate" within a dedicated subdirectory. Previously, the shadow crate was stored directly under Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the directory structure for build artifacts generated by Hermes. The shadow crate is now stored in target/hermes/<hash>/shadow instead of target/hermes_shadow_<hash>, which better isolates it and allows for other artifacts to be stored alongside it. The implementation introduces a hermes_run_root in the Roots struct and a shadow_root() method for better encapsulation. The related functions and integration tests have been updated accordingly. The changes are well-structured, correct, and improve the organization of build artifacts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G833f306c404eb4d4f3d920a8b169a5570b3806a4 #3013 +/- ##
==========================================================================
Coverage 91.87% 91.87%
==========================================================================
Files 20 20
Lines 6057 6057
==========================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G7f8abd90b628d02a6fdc01985535eef50509312e
branch
from
0fe1018 to
7590938
Compare
joshlf
force-pushed
the
G833f306c404eb4d4f3d920a8b169a5570b3806a4
branch
from
c4916be to
1b5bc18
Compare
Previously, we stored the shadow crate in `target/hermes_shadow_<hash>`. Now we store it in `target/hermes/<hash>/shadow`. This allows us to store other build artifacts in `target/hermes/<hash>` but outside of `/shadow` to avoid polluting the shadow copy. gherrit-pr-id: G7f8abd90b628d02a6fdc01985535eef50509312e
joshlf
force-pushed
the
G833f306c404eb4d4f3d920a8b169a5570b3806a4
branch
from
1b5bc18 to
b6dc5d4
Compare
joshlf
force-pushed
the
G7f8abd90b628d02a6fdc01985535eef50509312e
branch
from
7590938 to
b3bfc03
Compare
2 participants
Previously, we stored the shadow crate in
target/hermes_shadow_<hash>.Now we store it in
target/hermes/<hash>/shadow. This allows us tostore other build artifacts in
target/hermes/<hash>but outside of/shadowto avoid polluting the shadow copy.mod foo;declarations #3008Latest Update: v26 — Compare vs v25
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G7f8abd90b628d02a6fdc01985535eef50509312e && git checkout -b pr-G7f8abd90b628d02a6fdc01985535eef50509312e FETCH_HEADCheckout
git fetch origin refs/heads/G7f8abd90b628d02a6fdc01985535eef50509312e && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G7f8abd90b628d02a6fdc01985535eef50509312e && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.