[hermes] Add some tests for Charon invocation #3015
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing infrastructure for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable set of test fixtures for various hermes invocation scenarios, covering crate/target selection, name collisions, and cases with no annotations. These tests significantly improve the coverage of the command-line interface and project resolution logic. The fixtures are well-organized and clear. I have one suggestion to enhance the robustness of a test by using a more specific expected error message.
| @@ -0,0 +1 @@ | |||
| No Hermes annotations | |||
There was a problem hiding this comment.
The expected stderr message is very generic. The actual error message produced is "No Hermes annotations (/// ```lean ...) found in the selected targets. Nothing to verify.". While the test likely passes using a substring match, making the expected error more specific would make the test more robust. This prevents the test from passing incorrectly if other error messages are added in the future that also contain this short substring.
No Hermes annotations (/// ```lean ...) found in the selected targets. Nothing to verify.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Ge1bd84b5d857e18e3668e809844c6d73b808a020 #3015 +/- ##
============================================================================
Coverage ? 91.87%
============================================================================
Files ? 20
Lines ? 6057
Branches ? 0
============================================================================
Hits ? 5565
Misses ? 492
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G60bb1cd41a5fade3144a05f2bdafb2a670059e03
branch
4 times, most recently
from
8391931 to
8f20400
Compare
joshlf
force-pushed
the
G60bb1cd41a5fade3144a05f2bdafb2a670059e03
branch
from
8f20400 to
f187d94
Compare
joshlf
force-pushed
the
Ge1bd84b5d857e18e3668e809844c6d73b808a020
branch
from
3434d56 to
bc49806
Compare
gherrit-pr-id: G60bb1cd41a5fade3144a05f2bdafb2a670059e03
joshlf
force-pushed
the
Ge1bd84b5d857e18e3668e809844c6d73b808a020
branch
from
bc49806 to
c0c7f26
Compare
joshlf
force-pushed
the
G60bb1cd41a5fade3144a05f2bdafb2a670059e03
branch
from
f187d94 to
5660a8c
Compare
2 participants
mod foo;declarations #3008Latest Update: v23 — Compare vs v22
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G60bb1cd41a5fade3144a05f2bdafb2a670059e03 && git checkout -b pr-G60bb1cd41a5fade3144a05f2bdafb2a670059e03 FETCH_HEADCheckout
git fetch origin refs/heads/G60bb1cd41a5fade3144a05f2bdafb2a670059e03 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G60bb1cd41a5fade3144a05f2bdafb2a670059e03 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.