[hermes] Finalize removal of shadow crate code

[joshlf]

---

This PR is on branch hermes.

• 　  [hermes] Clean up after removing shadow crate support #3038
• 👉 [hermes] Finalize removal of shadow crate code #3037
• 　  [hermes] Remove diagnostic path mapping from shadow copy #3036
• 　  [hermes] Stop copying shadow crate; run in-place #3035
• 　  [hermes] Disable unsafe redaction #3034
• 　  [hermes] Take responsibility for all terminal UI #3019
• 　  [hermes] Get tests passing again #3018
• 　  [hermes] Add some tests for Charon invocation #3015
• 　  [hermes] Add Charon step #3014
• 　  [hermes] Isolate shadow crate from other artifacts #3013
• 　  [hermes] Add some trace/debug logging #3012
• 　  [hermes] Add one more UI test #3011
• 　  [hermes] Add fixture testing #3010
• 　  [hermes] Finish shadow crate creation #3009
• 　  [hermes] Discover mod foo; declarations #3008
• 　  [hermes] Resolve Cargo and Hermes target dirs #3007
• 　  [hermes] Add shadow copy creation #3006
• 　  [hermes] Add package/target/root resolution #3005
• 　  [hermes] Add source code transformation #3004
• 　  [hermes] Add UI testing #3003
• 　  [hermes] Initial commit of parser #3002

⬇️ Download this PR

Branch

git fetch origin refs/heads/Gtzihj5ol6a2xgdnfdresbbnwzaw25quk && git checkout -b pr-Gtzihj5ol6a2xgdnfdresbbnwzaw25quk FETCH_HEAD

Checkout

git fetch origin refs/heads/Gtzihj5ol6a2xgdnfdresbbnwzaw25quk && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gtzihj5ol6a2xgdnfdresbbnwzaw25quk && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gtzihj5ol6a2xgdnfdresbbnwzaw25quk

Stacked PRs enabled by GHerrit.

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the removal of the 'shadow crate' concept within the Hermes tool. It renames the shadow module to scanner and refactors its functionality to focus solely on scanning and collecting Hermes annotations, without performing any file system modifications. This change simplifies the architecture by decoupling the scanning logic from the creation of temporary files, making the process more efficient and cleaner.

Highlights

• Module Renaming and Refactoring: The shadow module has been completely replaced by a new scanner module, reflecting a shift in its core responsibility from building a 'shadow crate' to simply scanning for annotations.
• Codebase-Wide Updates: All references to the old shadow module, including imports and function calls, have been updated to point to the new scanner module across charon.rs, main.rs, and resolve.rs.
• Removal of File System Operations: The scanner module (formerly shadow) no longer performs file system operations such as creating directories or writing transformed files, streamlining the annotation scanning process and removing the 'shadow crate' concept entirely.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tools/hermes/src/charon.rs
  • Updated the import path for HermesArtifact from shadow to scanner.
• tools/hermes/src/main.rs
  • Changed the module import from shadow to scanner.
  • Replaced the call to shadow::build_shadow_crate with scanner::scan_workspace.
  • Updated the variable name entry_points to packages to reflect the new function's return type.
• tools/hermes/src/resolve.rs
  • Removed the shadow_root method, which was no longer needed after the removal of the shadow crate concept.
• tools/hermes/src/shadow.rs -> tools/hermes/src/scanner.rs
  • Renamed the file from shadow.rs to scanner.rs.
  • Removed unused imports (HashSet, fs, walkdir).
  • Renamed the main function from build_shadow_crate to scan_workspace.
  • Eliminated all code responsible for creating directories and writing files to a 'shadow' location, focusing the module purely on scanning.
  • Updated comments to reflect the new purpose of scanning without transformation.

Activity

• No specific activity (comments, reviews, progress updates) was provided in the pull request context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request finalizes the removal of the shadow crate concept by renaming the shadow module to scanner and eliminating the associated file-copying logic. The changes are well-focused and correctly implement the refactoring. I have one minor suggestion to fix a typo in a documentation comment to improve clarity.

[gemini-code-assist]

The word "rules" in this comment appears to be a typo. Considering the function's purpose of scanning and parsing files, perhaps you meant "parses"?

Suggested change

	/// 1. Scans and rules all reachable source files, printing any errors
	/// 1. Scans and parses all reachable source files, printing any errors

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (Gl2u5imkbil27nran4i72sxo5dzpixijo@6a51e27). Learn more about missing BASE report.

Additional details and impacted files

@@                         Coverage Diff                          @@
##             Gl2u5imkbil27nran4i72sxo5dzpixijo    #3037   +/-   ##
====================================================================
  Coverage                                     ?   91.87%           
====================================================================
  Files                                        ?       20           
  Lines                                        ?     6057           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     5565           
  Misses                                       ?      492           
  Partials                                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.