[hermes] Don't pass overly-long arguments to Charon #3044
Conversation
gherrit-pr-id: Gulbf5jp7zpz4nn77nspxpsiy3tadde54
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| // OS command-line length limits (Windows is ~32k; Linux `ARG_MAX` is | ||
| // usually larger, but variable) | ||
| const ARG_CHAR_LIMIT: usize = 32_768; |
There was a problem hiding this comment.
For better code organization and to signal that this constant is not dependent on the loop, consider defining ARG_CHAR_LIMIT and its explanatory comment outside the for loop, for example, at the function level. While const means no runtime cost, this improves readability and maintainability.
| "The list of Hermes entry points for package '{}' is too large ({} bytes). \n\ | ||
| This exceeds safe OS command-line limits.", |
There was a problem hiding this comment.
The indentation on this line will be included in the final error message string, which is likely not intended and will result in a large amount of whitespace at the beginning of the second line of the error message. Consider removing the leading spaces for cleaner output.
"The list of Hermes entry points for package '{}' is too large ({} bytes). \nThis exceeds safe OS command-line limits.",
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gtu5rhuk5rjkrhhqpfwbmniejgf57ogzn #3044 +/- ##
==================================================================
Coverage 91.87% 91.87%
==================================================================
Files 20 20
Lines 6057 6057
==================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR is on branch hermes.
#[cfg_attr(..., path = "...")]#3045unsaferedaction #3034mod foo;declarations #3008Latest Update: v9 — Compare vs v8
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gulbf5jp7zpz4nn77nspxpsiy3tadde54 && git checkout -b pr-Gulbf5jp7zpz4nn77nspxpsiy3tadde54 FETCH_HEADCheckout
git fetch origin refs/heads/Gulbf5jp7zpz4nn77nspxpsiy3tadde54 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gulbf5jp7zpz4nn77nspxpsiy3tadde54 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.