Skip to content

fix(advisor,codegen,cli): close the silent-failure gaps behind #283-#287 - #289

Merged
prisis merged 14 commits into
alphafrom
fix/advisor-gate-and-codegen-emission
Aug 2, 2026
Merged

prisis merged 14 commits into
alphafrom
fix/advisor-gate-and-codegen-emission

Conversation

@prisis

@prisis prisis commented Aug 1, 2026 •

Copy link
Copy Markdown
Member

Cluster A — the advisor gate silently breaks codegen chains (#284, #285)

  • advisor: storage_key_from_user_args has no reachability model — false-positive ERRORs gate codegen #284: storage_key_from_user_args had no reachability model. Both real
    hits were internalActions receiving a content-addressed storage id minted
    server-side. Fixed both suggested angles: attaches the enclosing procedure's
    visibility (mirroring owner_field_from_args_not_auth's existing split)
    and drops an internal* finding to INFO instead of ERROR, pointing at the
    public callers as the real audit surface; and added
    isUnmodifiedArgumentPassthrough so a key rebuilt by an intervening call (a
    hash, an encoder) is no longer treated as caller-controlled input reaching
    the sink verbatim. No new suppression mechanism added.
  • cli: advisory gate ignores its documented default; duplicate flag help; advisor --no-write rejected #285: all three parts.
    1. The gate ignoring "off locally": root cause was cerebro's own
      no-strict-advisories-only declaration — cerebro synthesizes the positive
      --strict-advisories counterpart with an unconditional defaultValue: true, so options.strictAdvisories was never undefined and the
      CI-vs-local fallback in resolveStrictAdvisories never ran. Now declares
      both --strict-advisories and --no-strict-advisories explicitly (in
      both codegen and deploy), neither with a default, so the fallback
      actually fires.
    2. Same root cause explains the duplicate help text: cerebro's synthesized
      option clones the negative flag's description verbatim. Declaring both
      forms ourselves gives each its own accurate text.
    3. lunora advisor --no-write was rejected as unknown because the option
      was declared under its positive name (write) — cerebro only
      synthesizes a no-* counterpart for a no-*-named declaration.
      Redeclared as no-write, matching the convention codegen/dev already
      use correctly.

Cluster B — codegen emits too little, silently (#283, #287)

  • codegen: not reproducible from a cold _generated/ — first run writes collapsed {} return types #283: codegen wasn't reproducible from a cold _generated/ — pass 1
    inferred handler return types before Doc<T>/Id<T>/typed ctx.db existed
    for a handler to resolve against, so a dependent return type collapsed to
    unknown and got written into api.ts/functions.ts. Bootstrapped:
    runCodegen now emits dataModel.ts (schema-only) and a provisional
    server.ts (schema-only core builders) before discoverFunctions runs,
    so pass 1 sees what pass 2 used to. The full server.ts overwrites the
    provisional one before the run returns, so a warm run pays nothing beyond
    two cheap string renders. Added a regression test that runs codegen from a
    genuinely cold _generated/ and asserts the first pass already matches a
    second pass.
  • codegen: emit resolveTableSharding/importGlobals — omitting them makes admin import a silent no-op #287: POST /_lunora/admin/import needed resolveTableSharding and
    importGlobals wired by hand; omitting either was silent (a .global()
    table routes to the default shard and GLOBAL_NOT_CONFIGURED never fires —
    200 with inserted: {}). Codegen now emits both inside the existing
    .global() block: resolveTableSharding is a mechanical lookup over each
    table's already-known shardMode, and importGlobals routes rows through
    the same D1 writer via @lunora/d1's importGlobalRows, mirroring
    runShardImport's shard-local twin. Verified against a real schema
    (apps/playground's .global() tables) with tsc --noEmit on the emitted
    output — no new type errors (one pre-existing, unrelated D1Database.batch
    narrowing error is untouched by this change).
    Not done: a .shardBy()-only project with no .global()/Hyperdrive
    table doesn't get resolveTableSharding emitted (the schema import is
    currently gated on hasGlobal/hasHyperdriveGlobal) — narrower than the
    reported bug (which is specifically about lost .global() tables), flagged
    as a follow-up rather than folded into this fix.

Golden fixture regenerated (app.ts only — the two new imports and two new
module-level helpers; dataModel.ts/server.ts/api.ts/functions.ts are
byte-identical).

Cluster C — nondeterministic_query_mutation (#286, a question)

I verified the runtime claim myself before acting, per the ticket's ask:

  • packages/do/src/shard-do.ts (~4331-4341): a mutation replay is deduped by
    (currentRequestUserId, mutationId) and short-circuits to the cached
    result before handleRpc (the handler) is ever called.
  • packages/shard-engine/src/transaction.ts: an OCC conflict throws
    ConflictError (409) back to the caller; shard-do.ts's dispatch catch
    block records it and propagates it — there is no internal catch-and-retry
    loop that re-invokes the handler.

So my own investigation confirms the reporter's finding for mutations: an
ordinary mutation handler runs at most once per logical write, and the rule's
"may be re-run on OCC retry" premise does not hold here. It does not
contradict — no STOP condition hit.

One refinement my reading adds: the premise does hold for queries — a
live subscription genuinely re-runs its query when a table it reads changes
(shard-do.ts's refreshSubscriptions), so Date.now() in a query can
legitimately flicker between evaluations. The codegen feeder already tags each
finding with kind: "query" | "mutation", so rather than a blanket downgrade I
split on that: query stays WARN, mutation drops to INFO (not silenced
— a mutation dispatched from a workflow step or queue consumer that itself
replays is a real residual caveat, so the finding stays as a breadcrumb to
that). Documented the guarantee in packages/server/docs/index.mdx under a
new "Determinism: what actually replays" section, including that
step/consumer caveat.

Closes #283
Closes #284
Closes #285
Closes #287

Summary by CodeRabbit

  • New Features

    • Added controls for strict advisories in code generation and deployment.
    • Improved generated admin bulk imports for globally sharded data.
    • Added more accurate storage-key detection and procedure visibility reporting.
    • Added explicit advisor write controls.
    • Added an invalid cron schedule error.
    • Improved import error reporting by preserving source row numbers.
  • Bug Fixes

    • Refined advisory severity and messaging for queries, mutations, and replayable workflows.
    • Improved schema-dependent type resolution during code generation.
    • Improved warning output when CLI logging is unavailable.
  • Documentation

    • Documented query re-evaluation, mutation deduplication, conflict handling, and replay limitations.

@netlify

netlify Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit c14cbf5
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6efbb415dc9c00084fe2fa
😎 Deploy Preview https://deploy-preview-289--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e3651efb-06f5-4b5f-828e-443a3e6f1f3c

📥 Commits

Reviewing files that changed from the base of the PR and between d6f4eb3 and c14cbf5.

⛔ Files ignored due to path filters (19)
  • api-snapshots/advisor.api.md is excluded by none and included by none
  • api-snapshots/d1.api.md is excluded by none and included by none
  • examples/auth-playground/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • examples/blog/lunora/_generated/app.ts is excluded by !**/_generated/** and included by none
  • examples/blog/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • examples/expo/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • examples/notify-demo/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • examples/offline-rejections/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • examples/realtime-cursors/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • examples/todo-app/lunora/_generated/shard.ts is excluded by !**/_generated/** and included by none
  • packages/advisor/__tests__/nondeterministic-query-mutation.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/advisor/__tests__/storage-key-from-user-args.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/cli/__tests__/commands/option-parsing.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/codegen/__tests__/discover-storage-key-accesses.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/codegen/__tests__/emit-app-global.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/codegen/__tests__/fixtures/simple/expected/_generated/app.ts is excluded by !**/_generated/**, !**/__tests__/** and included by packages/**
  • packages/codegen/__tests__/run-codegen-cold-start.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/d1/__tests__/admin-export-import.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/studio/__tests__/features/storage/file-browser.test.tsx is excluded by !**/__tests__/** and included by packages/**
📒 Files selected for processing (14)
  • packages/advisor/src/lints/static/nondeterministic-query-mutation.ts
  • packages/advisor/src/lints/static/storage-key-from-user-args.ts
  • packages/advisor/src/storage-key-accesses.ts
  • packages/cli/src/commands/advisor/index.ts
  • packages/cli/src/commands/codegen/index.ts
  • packages/cli/src/commands/deploy/index.ts
  • packages/codegen/src/argument-taint.ts
  • packages/codegen/src/discover-argument-derived-accesses.ts
  • packages/codegen/src/discover-storage-key-accesses.ts
  • packages/codegen/src/emit-app.ts
  • packages/codegen/src/ir.ts
  • packages/codegen/src/run-codegen.ts
  • packages/d1/src/admin-export-import.ts
  • packages/server/docs/index.mdx

Walkthrough

The PR updates advisor severity and storage-key classification, adds unmodified argument analysis and procedure visibility to codegen, bootstraps generated types, emits D1 admin-import wiring, corrects CLI boolean options, preserves logger binding, and adds an error catalog entry.

Changes

Advisor analysis

Layer / File(s) Summary
Storage-key finding classification
packages/advisor/src/storage-key-accesses.ts, packages/advisor/src/lints/static/storage-key-from-user-args.ts
Storage-key accesses now include optional visibility. Internal procedures produce informational internal findings. Public procedures retain external error findings.
Query and mutation determinism findings
packages/advisor/src/lints/static/nondeterministic-query-mutation.ts, packages/server/docs/index.mdx
Queries produce WARN findings for subscription re-evaluation. Ordinary mutations produce INFO findings. Workflow and queue replay behavior is documented.

Codegen analysis and bootstrap

Layer / File(s) Summary
Unmodified storage-key reachability
packages/codegen/src/argument-taint.ts, packages/codegen/src/discover-argument-derived-accesses.ts, packages/codegen/src/discover-storage-key-accesses.ts, packages/codegen/src/ir.ts
Storage-key discovery can require unchanged argument-derived values and propagates procedure visibility.
Schema-only codegen bootstrap
packages/codegen/src/run-codegen.ts
Non-dry runs write provisional generated declarations and refresh the project before function discovery.
Generated D1 admin import wiring
packages/codegen/src/emit-app.ts, packages/d1/src/admin-export-import.ts
Generated D1 workers resolve table sharding from the schema and route global rows through importGlobalRows, preserving physical source lines.

CLI and runtime support

Layer / File(s) Summary
Explicit CLI boolean options
packages/cli/src/commands/advisor/index.ts, packages/cli/src/commands/codegen/index.ts, packages/cli/src/commands/deploy/index.ts
The commands expose positive and negative write or strict-advisory flags with corrected descriptions and default handling.
Runtime and catalog support
packages/astro/src/integration.ts, packages/codegen/src/discover-procedure-middleware.ts, packages/errors/src/catalog.ts
The Astro warning helper preserves logger binding. ESLint suppressions document intentional AST traversal. The error catalog adds CRON_SCHEDULE_INVALID.
Formatting-only updates
packages/config/src/cloudflare/wrangler-validator.ts, packages/observability/src/query-metrics.ts, packages/shard-engine/src/ctx-db.ts
Existing declarations and callback blocks are reformatted without behavior changes.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant runCodegen
  participant GeneratedDeclarations
  participant FunctionDiscovery
  participant StorageKeyDiscovery
  participant GeneratedD1Worker
  participant importGlobalRows
  runCodegen->>GeneratedDeclarations: write schema-only declarations
  runCodegen->>GeneratedDeclarations: refresh generated source files
  runCodegen->>FunctionDiscovery: discover functions
  runCodegen->>StorageKeyDiscovery: analyze accesses with function visibility
  StorageKeyDiscovery-->>runCodegen: return classified storage-key accesses
  GeneratedD1Worker->>importGlobalRows: import global rows through D1 context
Loading

Possibly related PRs

Suggested labels: package: cli

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes #286 nondeterminism changes and unrelated formatting, Astro, cron-error, and observability changes not required by linked issues #283, #284, #285, or #287. Remove unrelated changes or link the corresponding issue, especially the #286 advisor/runtime work, and keep formatting and catalog changes in separate PRs.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main advisor, codegen, and CLI fixes and identifies the related issue range.
Description check ✅ Passed The description gives a detailed summary, linked issue coverage, and validation evidence, but omits explicit template sections for the test plan, checklist, notes, and CLA.
Linked Issues check ✅ Passed The implementation addresses the coding objectives for #283, #284, #285, and #287; excluded tests limit verification of regression coverage but do not prove a requirement is unmet.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/advisor-gate-and-codegen-emission

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
packages/advisor/src/lints/static/storage-key-from-user-args.ts (1)

34-66: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Duplicated emit() shape between the internal and default branches.

Both branches build the same cacheKey, reuse metadata, and call emit(storageKeyFromUserArgs, {...}), differing only in detail (and facing/level for the internal case). Consider a single emit() call with the branch computing only the varying fields (detail, and an optional facing/level override object).

As per path instructions, "Follow DRY principles" for packages/**/*.ts.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/advisor/src/lints/static/storage-key-from-user-args.ts` around lines
34 - 66, The internal and default branches in the storage-key lint duplicate the
emit call and shared fields. Refactor the map callback around
storageKeyFromUserArgs to compute the branch-specific detail plus optional
internal facing/level values, then invoke emit once with the shared cacheKey and
metadata while preserving the existing messages and defaults.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/codegen/src/emit-app.ts`:
- Around line 916-926: Update buildGlobalImporter so its rows mapping preserves
each row.line when constructing the input for importGlobalRows, allowing
non-contiguous global-row errors to report the original NDJSON line. Keep the
existing doc and table mapping and startLine behavior unchanged.

In `@packages/codegen/src/run-codegen.ts`:
- Around line 473-519: Update the bootstrap block around emitServer and
writeIfChanged so disk writes occur only when the generated bootstrap targets
are missing, avoiding replacement of warm-run full output with schema-only
content. Check bootstrapDataModelPath and bootstrapServerPath existence before
writing, while still registering the bootstrap contents with
project.createSourceFile when needed for in-memory discovery; preserve the final
full-feature emission and existing dry-run behavior.

In `@packages/server/docs/index.mdx`:
- Around line 132-140: Update the OCC documentation in the idempotency section
to remove the undefined ConflictError reference and describe the 409 response
and caller-controlled retry behavior without naming a specific error class.
Preserve the existing x-lunora-mutation-id and (identity, mutationId)
deduplication documentation unchanged.

---

Nitpick comments:
In `@packages/advisor/src/lints/static/storage-key-from-user-args.ts`:
- Around line 34-66: The internal and default branches in the storage-key lint
duplicate the emit call and shared fields. Refactor the map callback around
storageKeyFromUserArgs to compute the branch-specific detail plus optional
internal facing/level values, then invoke emit once with the shared cacheKey and
metadata while preserving the existing messages and defaults.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e447e99-986b-4400-b270-b97b1978de10

📥 Commits

Reviewing files that changed from the base of the PR and between 071c6a2 and 8598b2a.

⛔ Files ignored due to path filters (7)
  • packages/advisor/__tests__/nondeterministic-query-mutation.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/advisor/__tests__/storage-key-from-user-args.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/cli/__tests__/commands/option-parsing.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/codegen/__tests__/discover-storage-key-accesses.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/codegen/__tests__/emit-app-global.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/codegen/__tests__/fixtures/simple/expected/_generated/app.ts is excluded by !**/_generated/**, !**/__tests__/** and included by packages/**
  • packages/codegen/__tests__/run-codegen-cold-start.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
📒 Files selected for processing (13)
  • packages/advisor/src/lints/static/nondeterministic-query-mutation.ts
  • packages/advisor/src/lints/static/storage-key-from-user-args.ts
  • packages/advisor/src/storage-key-accesses.ts
  • packages/cli/src/commands/advisor/index.ts
  • packages/cli/src/commands/codegen/index.ts
  • packages/cli/src/commands/deploy/index.ts
  • packages/codegen/src/argument-taint.ts
  • packages/codegen/src/discover-argument-derived-accesses.ts
  • packages/codegen/src/discover-storage-key-accesses.ts
  • packages/codegen/src/emit-app.ts
  • packages/codegen/src/ir.ts
  • packages/codegen/src/run-codegen.ts
  • packages/server/docs/index.mdx

Comment thread packages/codegen/src/emit-app.ts Resolved
Comment thread packages/codegen/src/run-codegen.ts Resolved
Comment thread packages/server/docs/index.mdx Resolved
@codspeed

codspeed Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 250 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ in-batch: single IN(...) query + id->doc re-projection 790.1 µs 949.9 µs -16.82%
⚡ batched: one IN-list UNION-ALL probe across all tables (locateTablesByIds) 1.8 ms 1.4 ms +26.97%
⚡ count, no attributes 67.1 µs 60.4 µs +11.08%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/advisor-gate-and-codegen-emission (c14cbf5) with alpha (6a4dd72)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on alpha (9f7af4d) during the generation of this report, so 6a4dd72 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

github-actions Bot commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit c14cbf5.

storage_key_from_user_args had no reachability model: it flagged any
ctx.storage.* call whose key textually referenced args, with no regard
for whether the enclosing procedure has an untrusted caller, and no
check that the value reaches the sink unmodified. Both real false
positives were internalActions receiving a content-addressed id minted
server-side. Mirror owner_field_from_args_not_auth's existing
visibility split: attach the enclosing procedure's visibility to each
storage-key access and drop internal-procedure findings to INFO
(pointing at the public callers instead), and add
isUnmodifiedArgumentPassthrough so a value rebuilt by an intervening
call (a hash, an encoder) is no longer treated as caller-controlled
input reaching the sink verbatim.

Because storage_key_from_user_args is the only ERROR-level advisory
gating `lunora codegen`, these two false positives silently broke any
chained `lunora codegen && <next step>` script.

Separately, the gate itself ignored its own documented default. cerebro
synthesizes a `--strict-advisories` counterpart from a `no-*`-only
declaration by cloning its description verbatim (so both flags showed
the same "Don't fail..." help text) and giving the synthesized option
an unconditional `defaultValue: true` — so `options.strictAdvisories`
was never `undefined`, permanently overriding the CI-vs-local fallback
and making `lunora codegen`/`lunora deploy` strict locally regardless
of `--help`'s claim otherwise. Declaring both the positive and negative
forms explicitly, each with its own accurate description and no
default, fixes both.

Also fixes `lunora advisor --no-write`: the option was registered under
its positive name (`write`), so cerebro never synthesized the `no-*`
counterpart the command's own --help already advertised, and the flag
was rejected as unknown. Declaring it as `no-write` (matching every
other negatable flag in this CLI) makes the documented invocation work.

Closes #284, #285
This was referenced Aug 2, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026

This branch was previously deployed

1 inactive deployment
benchmarks — c14cbf5c Deployed Aug 2, 2026 by prisis via Benchmarks #1356
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.