Skip to content

ci: run ci-status through the report-ci-status composite - #208

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status-composite
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status-composite

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Refs: melodic-software/ci-workflows#1138

Summary

Second canary for ci-workflows#1138 (rollout step 2, public repository, hosted runner): the ci-status job now runs the shared report-ci-status composite (ci-workflows#1139, v0.76.0) instead of its own check-contract and aggregate-results steps. CI Status stays the job's name and the single required check, and its behavior is unchanged. No plugin component, skill, manifest or marketplace entry changes.

Fix

  • ci-status steps: one report-ci-status step (draft: allow, treat-skipped-as at its default fail, no exempt authors), then a "Fail on the contract or draft policy" step. That step fails on any contract or draft outcome other than success, so an empty or renamed output fails closed. This applies the review fix from songwriting#75.
  • The composite step keeps the name Aggregate lane results, so a contract-only run still finds the writer step of a full run recorded before this change.
  • Comments now say what the composite fixes (yield-to-full-run: 'true', carry-forward-wait-seconds: '0', the values this job set before) instead of naming inputs the file no longer sets.
  • Concurrency: unchanged; a push to main already falls back to github.run_id.
  • Lines: 28 removed, 32 added (git diff --numstat). Net +4, all comments that record the composite's fixed behavior. The step code alone shrinks from two composite steps with nine inputs to one step with three inputs plus the fail step.

AGENTS.md pull-request statements:

  • User goal and vertical slice: one source for the ci-status scaffold across the org's callers; this slice migrates this repository's caller only.
  • Live upstream URLs consulted, checked 2026-11-18: none of the OpenAI pages in docs/official-docs.md covers this surface (a CI workflow, no plugin component). The contract read was the composite's own README and action.yml at the pinned commit.
  • Context inputs and precedence: the rollout brief in ci-workflows#1138, then this repository's AGENTS.md and current workflow, whose settings are kept as they are.
  • Native surfaces selected: none (no plugin surface touched).
  • Ports and adapters introduced: none.
  • Defaults, configuration and fallbacks: the composite's defaults equal this workflow's previous explicit values, listed above.
  • Migration dispositions: not applicable (no plugin migration).

Verification

  • actionlint .github/workflows/pr-require-checks.yml: no findings.
  • Proof runs on this PR, all on head cf2136e:
    • Clean draft, opened: run 44388817898 passed. The draft is allowed, as before.
    • do-not-merge added: run 44388915550, contract-only, failed on the label with the lanes verdict carried forward.
    • Label removed, no push: run 44389012639, contract-only, passed.
  • Left out: npm test and npm run validate locally. They check plugins and the catalog, which this change does not touch, and this PR's Validate Marketplace lane runs both.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Replace the inline check-contract and aggregate-results steps with
ci-workflows' report-ci-status composite (v0.76.0) and a "Fail on the
contract or draft policy" step that fails on any outcome other than
success. Behavior is kept: draft allow, treat-skipped-as fail, no exempt
authors, sibling re-runs on, no yield wait. The composite step keeps the
name "Aggregate lane results" so a contract-only run still finds the
writer step of a full run recorded before this change. Concurrency
already falls back to github.run_id for a push.

Refs melodic-software/ci-workflows#1138

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton kyle-sexton added do-not-merge Hard merge gate: do not merge while applied. and removed do-not-merge Hard merge gate: do not merge while applied. labels Nov 18, 2026
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 20:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T20:19:16.964499Z cf2136e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed cf2136ea2c28d9854f79e96b43ae653b16a170b9: 0 finding(s), 0 as inline comments.

No inline findings. The diff (one file, .github/workflows/pr-require-checks.yml) swaps the check-contract and aggregate-results steps for one report-ci-status step plus a fail-closed step. I read it against the PR context and found nothing at the high-signal bar.

Checked

  • needs, if: ${{ !cancelled() }}, the job name CI Status and the permissions are unchanged.
  • The composite step keeps its old name through step-name: Aggregate lane results.
  • The new step Fail on the contract or draft policy is guarded by !cancelled(). It fails on any contract or draft output other than success, so an empty or renamed output fails closed.
  • treat-skipped-as stays at its default fail, which the PR states matches the old explicit value.
  • The lanes, their if: gating and the concurrency group are untouched, so nothing here loosens a gate.
  • The PR has no closing issue (Refs: only), so there were no acceptance criteria to check.
  • There were no settled-threads or prior-findings files and no plugin manifests in the diff.

Not verified: I could not read the composite's action.yml at ebd0e3b. The sandbox refused the gh api call. I did not confirm that the composite exposes contract and draft outputs, that it fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0', or that draft: allow makes the draft output success. The author's draft-PR proof run passing is consistent with the last point, but I did not check it.

Stale comment (advisory, not inline). The PR says the comments no longer name inputs the file does not set. Two comments outside the changed hunks still do:

  • Line 54 says "The aggregate-results composite closes that with yield-to-full-run". The workflow no longer uses that composite.
  • Lines 119-120 say check-contract upserts the linkage comment and ci-status records the status. The report-ci-status composite now does both. They are small to reword in this PR and misleading to the next reader.
Advisory and manifest lines (0)

Loosened-check verdict: fail, with no consumer entries. The wrapper wrote no loosened_check_* lines. The citation requirement was not checked. This change loosens no check.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed cf2136ea2c28d9854f79e96b43ae653b16a170b9: 0 finding(s), 0 as inline comments.

Security review: PR #208 (head cf2136e)

No security findings. critical-findings: 0

The PR changes one file, .github/workflows/pr-require-checks.yml. It replaces two pinned ci-workflows actions (check-contract and aggregate-results, both at v0.75.0) with one composite, report-ci-status, pinned to a full commit SHA with a # v0.76.0 comment. A new step then fails the job when the contract or draft output is not success.

This touches a ci-status hold step, so I read the whole change against the trust-control list.

  • Permissions: the job's permissions: block is unchanged (contents: read, pull-requests: write, statuses: write, actions: write). Only the comments changed, so no token scope grew.
  • Pin: the new action reference is a 40-character commit SHA. Pin hygiene is zizmor's lane in any case.
  • Fail-closed behavior: the new Fail on the contract or draft policy step runs under !cancelled() and fails unless both steps.report.outputs.contract and outputs.draft equal success. A missing or renamed output therefore fails the job, not passes it.
  • Skipped lanes: treat-skipped-as is not set, so the composite's default applies. The new comments state that default is fail, the same as the old explicit value. I did not read the composite to confirm it.
  • Draft policy: draft: allow matches the old behavior, because this workflow has no draft gate. The comment on that line says there is no ready_for_review trigger. Under the owner threat model (throughput phase), a person-approval or draft hold is not a finding in any case.
  • Superseded-run and carry-forward behavior: the comments say the composite fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0', which are the old explicit values. I did not read the composite to confirm this.
  • Token: the old steps passed token: ${{ github.token }} explicitly, and the new step passes no token input. If the composite defaults to github.token, the effective token is the same, and the job's permissions bound it either way. I could not confirm the default.
  • Injection: no github context expression is interpolated into run:. The run: body is a static echo and exit.

I could not read the composite's action.yml at the pinned SHA, because the fetch was blocked in this sandbox. Its internals are therefore unverified: whether it still runs the contract check and what its token default is. The diff itself shows no widening of trust, token scope, or what untrusted text reaches the job. The report step's id is new, and it is read only in the static if: expression.

No manifest changes, so there are no manifest lines. Nothing was settled or already posted: no settled-threads or prior-findings files were supplied. The protected-class instruction register was not consulted, because the diff removes no standing instruction.

@kyle-sexton
kyle-sexton merged commit e21295b into main Nov 18, 2026
18 of 19 checks passed
@kyle-sexton
kyle-sexton deleted the ci/report-ci-status-composite branch November 18, 2026 20:19
kyle-sexton added a commit to melodic-software/cursor-plugins that referenced this pull request Nov 18, 2026
No related issue: a rollout step of melodic-software/ci-workflows#1138,
which stays open until every repository has migrated.

## Summary

Rollout of
[ci-workflows#1138](melodic-software/ci-workflows#1138):
the `ci-status` job now runs the shared `report-ci-status` composite
([ci-workflows#1139](melodic-software/ci-workflows#1139),
v0.76.0) instead of its own `check-contract` and `aggregate-results`
steps. `CI Status` stays the job's name and the single required check.
Worked examples copied:
[songwriting#75](melodic-software/songwriting#75)
and
[codex-plugins#208](melodic-software/codex-plugins#208).

## Fix

- `ci-status` steps: one `report-ci-status` step (`draft: allow`, since
the job had no draft refusal and the workflow has no `ready_for_review`
trigger; `treat-skipped-as` at its default `fail`, the value set before;
no exempt authors, as before), then a "Fail on the contract or draft
policy" step that fails on any outcome other than `success`, so an empty
or renamed output fails closed.
- The composite step keeps the name `Aggregate lane results`, so a
contract-only run still finds the writer step of a full run recorded
before this change.
- Comments describe what the composite fixes (`yield-to-full-run:
'true'`, `carry-forward-wait-seconds: '0'`, the values this job set
before, [action.yml
L128-L129](https://github.com/melodic-software/ci-workflows/blob/ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129))
instead of inputs the file no longer sets.
- Concurrency: the fallback for a run with no pull request number (push
to `main`, `merge_group`, `workflow_dispatch`) changes from `github.ref`
to `github.run_id`, so every push to `main` keeps its own result instead
of a newer push cancelling the older one. This matches the composite's
reference copy. The comment that recorded the old `github.ref` decision
is rewritten.
- Job `if:` (`!cancelled()`), `needs`, permissions, runner and timeout
are unchanged.
- Lines: 39 removed, 41 added (`git diff --numstat`).

## Verification

- `actionlint .github/workflows/pr-require-checks.yml`: no findings.
- Runs on this PR, all on head `2f2a1f7`:
- Full run, `opened` (draft, allowed as before): [run
44390279944](https://github.com/melodic-software/cursor-plugins/actions/runs/44390279944)
passed.
- `do-not-merge` added: [run
44390727102](https://github.com/melodic-software/cursor-plugins/actions/runs/44390727102),
contract-only, failed: `check-contract: this PR carries the
'do-not-merge' label`, then the fail step exited 1.
- Label removed, no push: [run
44390874497](https://github.com/melodic-software/cursor-plugins/actions/runs/44390874497),
contract-only (every lane skipped), `CI Status` passed with the lanes
verdict carried forward.

## Related

- Design and rollout:
[ci-workflows#1138](melodic-software/ci-workflows#1138).
Composite:
[ci-workflows#1139](melodic-software/ci-workflows#1139).
- Revert: revert this PR; the old steps come back unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/agent-plugins that referenced this pull request Nov 18, 2026
No related issue: a rollout step of melodic-software/ci-workflows#1138,
which stays open until every repository has moved.

## Summary

Rollout of
[ci-workflows#1138](melodic-software/ci-workflows#1138):
the `ci-status` job now runs the shared `report-ci-status` composite
([ci-workflows#1139](melodic-software/ci-workflows#1139),
v0.76.0, pinned at `ebd0e3b`) instead of its own `check-contract` and
`aggregate-results` steps. `CI Status` stays the job's name and the
single required check, and its behavior is unchanged.

## Fix

- `ci-status` steps: one `report-ci-status` step named `Aggregate lane
results` (`id: report`), then "Fail on the contract or draft policy",
which fails on any contract or draft outcome other than `success` (fails
closed).
- Kept: `draft: allow` (the job had no draft refusal and no
`ready_for_review` trigger), no exempt authors (none before),
`treat-skipped-as` at the default `fail` (the old step set `fail`), the
job's `if: ${{ !cancelled() }}`, `needs`, permissions, runner, timeout
and the `merge_group` trigger.
- The composite fixes `yield-to-full-run: 'true'` and
`carry-forward-wait-seconds: '0'` ([action.yml
L128-L129](https://github.com/melodic-software/ci-workflows/blob/ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129))
and keeps `rerun-contract-only-siblings` at `true`: the values this job
set before. Comments now describe the composite instead of inputs the
file no longer sets.
- Concurrency: unchanged; a push already falls back to `github.run_id`.
- Lines: 33 removed, 37 added (`git diff --numstat`); the added lines
are comments recording the composite's fixed behavior.

## Verification

- `actionlint .github/workflows/pr-require-checks.yml`: no findings.
- `CI Status` on this PR's head: see the checks. The label proof
(do-not-merge fails, removal passes with no push) was run once for the
rollout, on
[agent-automations#73](melodic-software/agent-automations#73).

## Related

- Design and rollout:
[ci-workflows#1138](melodic-software/ci-workflows#1138).
Composite:
[ci-workflows#1139](melodic-software/ci-workflows#1139).
- Worked examples:
[songwriting#75](melodic-software/songwriting#75)
(draft: refuse),
[codex-plugins#208](melodic-software/codex-plugins#208)
(draft: allow).
- Revert: revert this PR; the old steps come back unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/claude-code-account-rotation that referenced this pull request Nov 18, 2026
Refs: melodic-software/ci-workflows#1138

## Summary

Rollout of
[ci-workflows#1138](melodic-software/ci-workflows#1138):
the `ci-status` job now runs the shared `report-ci-status` composite
([ci-workflows#1139](melodic-software/ci-workflows#1139),
v0.76.0, pinned at `ebd0e3b`) instead of its own `check-contract` and
`aggregate-results` steps. `CI Status` stays the job's name and the
single required check, and its behavior is unchanged. No product code,
CHANGELOG or release surface changes.

## Fix

- `ci-status` steps: one `report-ci-status` step named `Aggregate lane
results` (`id: report`), then "Fail on the contract or draft policy",
which fails on any contract or draft outcome other than `success` (fails
closed).
- Kept: the job's `if: always()`, `draft: allow` (the job never refused
a draft; `ready_for_review` stays in the triggers), `exempt-authors:
'dependabot[bot],melodic-standards-sync[bot]'`, `treat-skipped-as` at
the default `fail` (the old step set `fail`), `results` from
`join(needs.*.result, ' ')`, `needs`, permissions, runner and timeout.
- The composite fixes `yield-to-full-run: 'true'` and
`carry-forward-wait-seconds: '0'` ([action.yml
L128-L129](https://github.com/melodic-software/ci-workflows/blob/ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129))
and keeps `rerun-contract-only-siblings` at `true`: the values this job
set before. Comments now describe the composite instead of inputs the
file no longer sets.
- Concurrency: unchanged; a push already falls back to `github.run_id`.
- Lines: 42 removed, 44 added (`git diff --numstat`); the added lines
are comments recording the composite's fixed behavior.

## Verification

- `actionlint .github/workflows/pr-require-checks.yml`: no findings.
- `CI Status` on this PR's head: see the checks. The label proof was run
once for the rollout, on
[agent-automations#73](melodic-software/agent-automations#73).

## Related

- Worked examples:
[songwriting#75](melodic-software/songwriting#75)
(draft: refuse),
[codex-plugins#208](melodic-software/codex-plugins#208)
(draft: allow).
- Revert: revert this PR; the old steps come back unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/standards that referenced this pull request Nov 18, 2026
…composite (#1066)

Closes #1065

## Summary

The caller-pin audit (`maintenance-audit-pr-convention-pins.yml`) found
each consumer's contract gate only by a direct `uses:
.../pr-require-checks/check-contract@<sha>` call site. Callers on the
`report-ci-status` composite
([ci-workflows#1139](melodic-software/ci-workflows#1139),
v0.76.0) run `check-contract` through `$/` at the commit they pin, so
the scan reported them as running no contract artifact. That covers
[songwriting#75](melodic-software/songwriting#75)
and
[codex-plugins#208](melodic-software/codex-plugins#208),
both merged today, ci-workflows' own
`$/.github/actions/pr-require-checks/report-ci-status` call, and the
rest of the
[ci-workflows#1138](melodic-software/ci-workflows#1138)
rollout. The next push to `main` or the Wednesday run would have gone
red.

## Fix

- `components/pr-convention-policy/lockstep-drift.mjs`:
`detectArtifactPin` matches either composite directory, `check-contract`
or `report-ci-status` (new export `REPORT_DIRECTORY`), in both the
pinned form and the local `./`/`$/` form. Both resolve to `kind:
"composite"` at the same SHA, so the existing check reads
`check-contract` at that commit, which is the one that gates.
- `lockstep-drift.test.mjs`: cases for a pinned `report-ci-status`
caller, a `$/` one, and a commented-out `$/` one.
- Lines (`git diff --numstat`): 2 removed, 28 added.

## Verification

- `node --test components/pr-convention-policy/lockstep-drift.test.mjs`:
96 passed, 0 failed (about 6.5 minutes locally, most of it the hook
behavior probes).
- Not run locally: `npm run audit:pr-convention-pins`, which needs the
standards-sync App token that only a `main` run mints. The first push to
`main` after merge runs it.

## Related

-
[ci-workflows#1138](melodic-software/ci-workflows#1138)
(design and rollout). This repository's own migration follows in a
separate PR, with the matching `commit-convention.test.sh` change.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/.github that referenced this pull request Nov 18, 2026
No related issue: a rollout step of melodic-software/ci-workflows#1138,
which stays open until every repository has migrated.

## Summary

Rollout of
[ci-workflows#1138](melodic-software/ci-workflows#1138):
the `ci-status` job now runs the shared `report-ci-status` composite
([ci-workflows#1139](melodic-software/ci-workflows#1139),
v0.76.0) instead of its own `check-contract` and `aggregate-results`
steps. `CI Status` stays the job's name and the single required check.
Worked examples copied:
[songwriting#75](melodic-software/songwriting#75)
and
[codex-plugins#208](melodic-software/codex-plugins#208).

## Fix

- `ci-status` steps: one `report-ci-status` step, then a "Fail on the
contract or draft policy" step that fails on any outcome other than
`success`, so an empty or renamed output fails closed. The composite
step keeps the name `Aggregate lane results`, so a contract-only run
still finds the writer step of a full run recorded before this change.
- Behavior kept:
- `draft: allow`: the job had no draft refusal and the workflow has no
`ready_for_review` trigger.
- `treat-skipped-as: pass`, now explicit. The old `aggregate-results`
step set nothing and so ran on that action's default, `pass`
([aggregate-results action.yml at
v0.75.0](https://github.com/melodic-software/ci-workflows/blob/24067add42f5fa04743c587c6a22aa7d4059e7b8/.github/actions/pr-require-checks/aggregate-results/action.yml));
the composite's default is `fail`.
- The job's `if: always()`, `needs`, permissions, runner and timeout are
unchanged. No exempt authors, as before.
- Concurrency: unchanged; a push already falls back to `github.run_id`.
- Comments describe what the composite fixes (`yield-to-full-run:
'true'`, `carry-forward-wait-seconds: '0'`, [action.yml
L128-L129](https://github.com/melodic-software/ci-workflows/blob/ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129))
instead of inputs the file no longer sets.
- `.github/scripts/pr-section-drift.mjs` read the `check-contract@<sha>`
pin from this workflow and would have failed the `Check PR Sections`
lane with no such pin. It now also accepts the `report-ci-status@<sha>`
pin, since that composite runs `check-contract` through `$/` at its own
commit, and fetches `check-contract/run.sh` at that SHA as before. Two
cases added to its test.
- Lines (`git diff --numstat`): workflow 32 removed, 42 added;
`pr-section-drift.mjs` 5 removed, 11 added; its test 14 added.

## Verification

- `actionlint .github/workflows/pr-require-checks.yml`: no findings.
- `node --test .github/scripts/pr-section-drift.test.mjs`: 29 passed.
- `node .github/scripts/pr-section-drift.mjs` on this branch: "local
mirrors match
melodic-software/ci-workflows@ebd0e3b
section_report calls [Summary, Fix, Verification, Related]".

## Related

- Design and rollout:
[ci-workflows#1138](melodic-software/ci-workflows#1138).
Composite:
[ci-workflows#1139](melodic-software/ci-workflows#1139).
The fleet pin audit learns the same pin in
[standards#1065](melodic-software/standards#1065).
- Revert: revert this PR; the old steps come back unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/standards that referenced this pull request Nov 18, 2026
No related issue: a rollout step of melodic-software/ci-workflows#1138,
which stays open until every repository has migrated.

## Summary

Rollout of
[ci-workflows#1138](melodic-software/ci-workflows#1138):
the `ci-status` job now runs the shared `report-ci-status` composite
([ci-workflows#1139](melodic-software/ci-workflows#1139),
v0.76.0) instead of its own `check-contract` and `aggregate-results`
steps. `CI Status` stays the job's name and the single required check.
Worked examples copied:
[songwriting#75](melodic-software/songwriting#75)
and
[codex-plugins#208](melodic-software/codex-plugins#208).
Merge after
[#1066](#1066), which
teaches the fleet pin audit the same pin.

## Fix

- `ci-status` steps: one `report-ci-status` step, then a "Fail on the
contract or draft policy" step that fails on any outcome other than
`success`, so an empty or renamed output fails closed. The composite
step keeps the name `Aggregate lane results`, as `step-name` did before.
- Behavior kept:
  - `draft: allow`: the workflow is not draft-gated.
  - `exempt-authors: 'dependabot[bot]'`.
- `treat-skipped-as` at the composite's default `fail`, the value set
before.
- The job's `if: !cancelled()`, `needs`, permissions, runner and
`timeout-minutes: 8` are unchanged.
- Concurrency: unchanged; a push already falls back to `github.run_id`.
- Comments describe what the composite fixes (`yield-to-full-run:
'true'`, `carry-forward-wait-seconds: '0'`, [action.yml
L128-L129](https://github.com/melodic-software/ci-workflows/blob/ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129))
instead of inputs the file no longer sets.
- `components/commit-convention/commit-convention.test.sh` read the
`check-contract@<sha>` pin from this workflow to fetch the `types`
default, and would have failed `Check PR Convention Copies` with no such
pin. It now accepts the `report-ci-status@<sha>` pin too: that composite
runs `check-contract` through `$/` at its own commit, so the test still
fetches `check-contract/action.yml` at that SHA.
- Lines (`git diff --numstat`): workflow 31 removed, 35 added;
`commit-convention.test.sh` 3 removed, 5 added.

## Verification

- `actionlint .github/workflows/pr-require-checks.yml`: no findings.
- The test's new `sed` on this branch's workflow prints
`ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f`; `bash -n` on the test
passes. The full test runs in this PR's `Check PR Convention Copies`
lane.

## Related

- Design and rollout:
[ci-workflows#1138](melodic-software/ci-workflows#1138).
Pin audit:
[#1065](#1065) /
[#1066](#1066).
- Revert: revert this PR; the old steps come back unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/ci-runner that referenced this pull request Nov 19, 2026
Refs: melodic-software/ci-workflows#1138

## Summary

Moves the `ci-status` job in `.github/workflows/pr-require-checks.yml`
onto ci-workflows' `report-ci-status` composite ([design:
ci-workflows#1138](melodic-software/ci-workflows#1138)),
following the worked examples
[songwriting#75](melodic-software/songwriting#75)
and
[codex-plugins#208](melodic-software/codex-plugins#208).
The composite is pinned at `9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8 #
v0.76.3`, the same commit every other ci-workflows action in this file
uses since #587, so the one-pin inventory still holds.

## Fix

- The "Check the pull-request contract" and "Aggregate lane results"
steps become one `report-ci-status` step that keeps the name `Aggregate
lane results` (now `id: report`), so a contract-only run still finds the
full run's writer step by that name.
- A new step, "Fail on the contract or draft policy", fails the job when
`steps.report.outputs.contract` or `.draft` is anything but `success`
(fails closed).
- Behavior kept: `draft: allow` (the job had no "Refuse a draft" step),
`exempt-authors: 'dependabot[bot],melodic-standards-sync[bot]'`,
`treat-skipped-as: pass` (the composite defaults to `fail`),
`rerun-contract-only-siblings: 'true'`, `step-name`, and the job's `if:
always()`, `needs`, permissions, runner and `timeout-minutes: 3`. The
composite fixes `yield-to-full-run: 'true'` and
`carry-forward-wait-seconds: '0'` ([action.yml
L128-L129](https://github.com/melodic-software/ci-workflows/blob/9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129));
`token` and `enforce-hold-label` fall to defaults equal to the old ones
(`github.token`, `false`).
- Concurrency: unchanged. The push fallback is already `github.run_id`.
- `.github/scripts/workflow-pin-metadata.test.cjs`: the caller inventory
names `report-ci-status` in place of `aggregate-results` and
`check-contract`; the pin scan skips full-line YAML comments, since the
composite link above is a comment that calls nothing; a new test asserts
the `id: report` step keeps its name and that a later step fails on any
contract or draft outcome but `success`.

Lines changed (`git diff --numstat`): workflow +43/-33, test +20/-3.

## Verification

- `node --test ".github/scripts/**/*.test.cjs"`: 39 passed, 0 failed.
The new fail-closed test failed when the gate's condition was changed to
`== 'failure'`, then passed once it was restored.
- `pwsh ./scripts/Test-ReleasePins.ps1`: "Release and workflow pins are
internally consistent."
- `actionlint` on the workflow: no findings; lefthook pre-commit and
pre-push hooks passed.

## Related

- Design and rollout:
melodic-software/ci-workflows#1138
- Worked examples:
melodic-software/songwriting#75,
melodic-software/codex-plugins#208

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant