Skip to content

Add selectable Voxtype and Superwhisper dictation - #14552

Merged
dhh merged 17 commits into
quattrofrom
dictation-backends
Oct 8, 2026
Merged

dhh merged 17 commits into
quattrofrom
dictation-backends

Conversation

@dhh

@dhh dhh commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Make dictation available through Setup → Defaults → Dictation, with Voxtype and Superwhisper sharing Right Alt/F9 push-to-talk and Super + Ctrl + X toggle.

omarchy-default-dictation reads the saved selection or launches a backend-specific installer. Installers configure the provider and save the selection in ${XDG_CONFIG_HOME:-$HOME/.config}/omarchy/defaults/dictation after successful setup. Missing Voxtype is installed with confirmation; setup retries repair incomplete model/service installation while preserving custom configuration and reusing existing models. Superwhisper uses its OPR package and packaged user setup. A one-time migration preserves Voxtype for existing users who have no saved selection; runtime autodetection remains absent. No portable-install migration or legacy personal Hyprland cleanup is included.

omarchy-dictation only handles start, stop, and toggle. It requires an explicit selection and calls omarchy-dictation-<backend> with the action. Small adapters implement this protocol for Voxtype and Superwhisper. Third-party backends can provide their own adapter and installer without changing Omarchy; the manual documents the protocol. Optional backend desktop integration loads from Omarchy defaults, with broken integration files contained, and recording bindings are enabled only when a backend is explicitly selected, using the compositor-safe shell helper. omarchy-dictation-use <backend> stops the previous provider under the same lock used for recording commands, then saves the new choice with an atomic rename. Failed stops preserve the existing selection; missing adapters and stopped provider services allow recovery. The built-in bar dictation indicator and its status follower are removed; dictation providers supply their own recording overlays. Remove → Dictation lists the installed Voxtype and Superwhisper backends. Removing either backend clears its own saved selection without automatic fallback.

Depends on omacom/omarchy-pkgs#854 being merged and superwhisper-bin being published before Superwhisper installation is available.

Validation: full CLI suite and focused dictation, Hyprland defaults/binding conflicts, menu/guards, and invitation suites pass. Tests exercise an external adapter and installer, missing/invalid configuration, recording error propagation, failed/cancelled setup preserving selection, and broken/missing integrations. The Defaults menu was visually verified earlier. The running bar was visually verified after removing dictation, with all remaining indicators revealed, and the graphical indicator contract tests pass. The configured/unconfigured binding gate was checked in the running compositor. Claude reviewed the implementation and re-reviewed the fixes with no blocking findings; its remaining stopped-Superwhisper case was addressed with a focused regression test. Focused migration and package setup tests pass. Tested shortcut setup with the real vendor daemon, isolated configuration/runtime, and a mocked compositor exposing Omarchy Right Alt binds: upstream defaults reproduce the conflict, while the package-seeded defaults permit both CLI changes. No audio was recorded; this is not a full fresh-VM install test.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge, subject to the stated Superwhisper package publication dependency.

Summary

Adds selectable Voxtype and Superwhisper dictation through Setup → Defaults → Dictation.

  • Recording commands use the explicitly selected provider.
  • Provider switches stop the previous provider before saving the new choice.
  • Installers finish setup before selecting a provider; removers clear only their own selection.
  • The latest changes align the saved selection path, rename the selection helper, and move removal choices into their own category.
  • All four earlier, unnumbered findings are addressed: switching stops the old provider, selection writes are atomic, the manual no longer promises legacy cleanup, and Voxtype setup retries unfinished steps.
  • No new actionable issues or mounted-rule violations were found. Checks were based on source inspection; no runtime or visual verification was performed in this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Menu["Defaults → Dictation"] --> Installer["Provider installer"]
  Installer --> Setup["Finish provider setup"]
  Setup --> Use["omarchy-dictation-use"]
  Use --> Lock["Acquire shared lock"]
  Lock --> Stop["Stop previous provider"]
  Stop --> Save["Atomically save selection"]
  Keys["Recording shortcuts"] --> Record["omarchy-dictation"]
  Record --> LockRead["Acquire shared lock and read selection"]
  LockRead --> Adapter["Selected provider adapter"]
Loading

Reviews (9) · Last reviewed commit: "Move dictation removers into their own m..." · Reviewed by Greptile

Comment thread bin/omarchy-dictation Resolved
Comment thread bin/omarchy-dictation Resolved
@jandrusk

jandrusk commented Oct 8, 2026

Copy link
Copy Markdown

Nice consolidation. A few things I spotted while reading the diff:

Blocking: migration filename collision. migrations/1791403252.sh is also added by #14551 (OPR priority) and #14541 (Surface MODULES). Whichever lands second overwrites the other's migration, and machines that already ran the first one would never run the second. One of them needs a fresh timestamp (omarchy-dev-add-migration --no-edit). Note that #14541 also hard-codes /var/lib/omarchy/migrations/1791403252 as its rebuild marker, so that needs to change along with its filename.

F9 / Right Alt are now bound for everyone. bindings/voxtype.lua only bound these keys when voxtype was present. bindings/dictation.lua binds F9, ALT + Alt_R (with ignore_mods) and SUPER + CTRL + X unconditionally. So on a machine with no dictation backend, F9 gets swallowed from apps (mc, IDE debuggers, file managers), and every Right Alt press runs omarchy-dictation start, which then exits with "No dictation backend installed". If "bindings available independently of providers" is the intent, that's fine, but a guard keeps the old behavior for people who never install dictation:

if o.cmd_present("voxtype") or o.cmd_present("superwhisper") then
  o.bind("SUPER + CTRL + X", "Toggle dictation", "omarchy-dictation toggle")
  -- ...
end

Both install paths already hyprctl reload afterwards, so the binds would show up right after install.

It might also be worth confirming that US-layout users who use Right Alt as a regular Alt modifier (Right Alt+Tab etc.) won't start and stop a recording on every chord.

The migration can wedge the queue. 1791403252.sh ends with omarchy-dictation backend superwhisper, which exits 1 if superwhisper shortcuts set … fails (for example, mid-recording, or if the app isn't reachable during omarchy update). Under bash -euo pipefail that leaves the migration and everything after it pending. Since the selection can be redone from the menu, maybe make that last step non-fatal (|| true, with a notification), or check that superwhisper shortcuts works in a non-graphical update context.

Comment thread manual/11-text-extraction-dictation.md Resolved
Comment thread bin/omarchy-install-dictation-voxtype Resolved
@dhh
dhh merged commit c248890 into quattro Oct 8, 2026
1 check passed
@dhh
dhh deleted the dictation-backends branch October 8, 2026 18:39
omarchybot added a commit to chessing234/omarchy that referenced this pull request Oct 8, 2026
Resolves the conflict with omacom#14552, which replaced the Voxtype binding tests with backend-neutral dictation tests and reused the same missing_bin symlinks. The command -p resolution now feeds the dictation and Lazydocker cases that share that directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omarchybot added a commit to chessing234/omarchy that referenced this pull request Oct 8, 2026
…aller

omacom#14552 replaced bin/omarchy-voxtype-install with bin/omarchy-install-dictation-voxtype, which still runs `voxtype setup gpu --enable || true` as the user. The fix moves to the new installer unchanged, and the test now drives that script with a fresh config directory each run, since the GPU step only runs when no Voxtype config exists yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexvlis added a commit to alexvlis/omarchy that referenced this pull request Oct 9, 2026
Keep the status helper deleted by omacom#14552. Upstream removed its bar
consumer and the GPU-probing path, so the original fix is superseded.
sogamoso added a commit to sogamoso/dotfiles that referenced this pull request Oct 14, 2026
Omarchy added hold-to-talk dictation on Right Alt next to its Super+Ctrl+X toggle (omacom/omarchy#14552, #14645). Alt is Command here, and Raycast's Dictate command switches to push-to-talk when its hotkey is held, so Right Command alone covers both. Raycast keeps one hotkey per command, so it replaces Option+Ctrl+X; the docs now say so.
omarchybot added a commit to CowGivesMilk/omarchy-fork that referenced this pull request Oct 15, 2026
Dictation's indicator was removed in omacom#14552, and PasswordlessSudo and RemoteSession were added since, so the list now matches defaultIndicatorEntries in shell/plugins/bar/widgets/Indicators.qml. Each name is the file under shell/plugins/bar/indicators/ that the widget loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@emirb emirb added this to the 4.5 milestone Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants